doc: remove synopsis - #65246
Conversation
Signed-off-by: avivkeller <me@aviv.sh>
7f876bf to
225a03f
Compare
|
Would URLs get redirected?
If not then I'd be inclined to not backport it to LTS releases. |
This comment was marked as resolved.
This comment was marked as resolved.
|
IMO synopsis is usefull. But we can discuss about merging |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65246 +/- ##
==========================================
- Coverage 90.31% 90.30% -0.02%
==========================================
Files 760 760
Lines 248637 248637
Branches 46942 46934 -8
==========================================
- Hits 224556 224523 -33
- Misses 15475 15515 +40
+ Partials 8606 8599 -7 🚀 New features to boost your workflow:
|
|
@MikeMcC399 I linked the wrong PR, the correct one was #59216 @AugustinMauroy @MikeMcC399 to quote myself in that PR:
|
|
got your idea. But IMO there are several people who just read the docs and not ressource aside or only have access to docs like in strange enterprise policy. So having small getting started on docs maybe a good thing. So what about in documentation/index having a link to run you first node => cli page, and cli page have example of console.log() and have a link to console api |
|
I'd love a second approval before landing this, so bump! |
Commit Queue failed- Loading data for nodejs/node/pull/65246 ✔ Done loading data for nodejs/node/pull/65246 ----------------------------------- PR info ------------------------------------ Title doc: remove synopsis (#65246) Author Aviv Keller <me@aviv.sh> (@avivkeller) Branch avivkeller:remove-synopsis -> nodejs:main Labels author ready, needs-ci, commit-queue, dont-land-on-v22.x, dont-land-on-v24.x, dont-land-on-v26.x Commits 1 - doc: remove synopsis Committers 1 - avivkeller <me@aviv.sh> PR-URL: https://github.com/nodejs/node/pull/65246 Reviewed-By: Claudio Wunder <cwunder@gnome.org> Reviewed-By: James M Snell <jasnell@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/65246 Reviewed-By: Claudio Wunder <cwunder@gnome.org> Reviewed-By: James M Snell <jasnell@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 12 Aug 2026 13:21:32 GMT ✔ Approvals: 2 ✔ - Claudio Wunder (@ovflowd): https://github.com/nodejs/node/pull/65246#pullrequestreview-4921213372 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/65246#pullrequestreview-4978614004 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/32329790908 |
|
Landed in 0ce7b02 |
As titled. Re-open of #59216
cc previous approvers: @marco-ippolito @ovflowd