Skip to content

doc: remove synopsis - #65246

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
avivkeller:remove-synopsis
Aug 20, 2026
Merged

doc: remove synopsis#65246
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
avivkeller:remove-synopsis

Conversation

@avivkeller

@avivkeller avivkeller commented Aug 12, 2026

Copy link
Copy Markdown
Member

As titled. Re-open of #59216

cc previous approvers: @marco-ippolito @ovflowd

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Aug 12, 2026
Signed-off-by: avivkeller <me@aviv.sh>
@richardlau

Copy link
Copy Markdown
Member

Would URLs get redirected?
e.g.

If not then I'd be inclined to not backport it to LTS releases.

@MikeMcC399

This comment was marked as resolved.

@avivkeller avivkeller added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. labels Aug 12, 2026
@AugustinMauroy

Copy link
Copy Markdown
Member

IMO synopsis is usefull. But we can discuss about merging index and documentation

@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.30%. Comparing base (00f0f8c) to head (225a03f).
⚠️ Report is 131 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65246      +/-   ##
==========================================
- Coverage   90.31%   90.30%   -0.02%     
==========================================
  Files         760      760              
  Lines      248637   248637              
  Branches    46942    46934       -8     
==========================================
- Hits       224556   224523      -33     
- Misses      15475    15515      +40     
+ Partials     8606     8599       -7     

see 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avivkeller

Copy link
Copy Markdown
Member Author

@MikeMcC399 I linked the wrong PR, the correct one was #59216

@AugustinMauroy @MikeMcC399 to quote myself in that PR:

@AugustinMauroy

Copy link
Copy Markdown
Member

got your idea. But IMO there are several people who just read the docs and not ressource aside or only have access to docs like in strange enterprise policy. So having small getting started on docs maybe a good thing.

So what about in documentation/index having a link to run you first node => cli page, and cli page have example of console.log() and have a link to console api

@avivkeller avivkeller added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 15, 2026
@avivkeller

Copy link
Copy Markdown
Member Author

I'd love a second approval before landing this, so bump!

@avivkeller avivkeller added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 20, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 20, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/65246
✔  Done loading data for nodejs/node/pull/65246
----------------------------------- PR info ------------------------------------
Title      doc: remove synopsis (#65246)
Author     Aviv Keller <me@aviv.sh> (@avivkeller)
Branch     avivkeller:remove-synopsis -> nodejs:main
Labels     author ready, needs-ci, commit-queue, dont-land-on-v22.x, dont-land-on-v24.x, dont-land-on-v26.x
Commits    1
 - doc: remove synopsis
Committers 1
 - avivkeller <me@aviv.sh>
PR-URL: https://github.com/nodejs/node/pull/65246
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65246
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 12 Aug 2026 13:21:32 GMT
   ✔  Approvals: 2
   ✔  - Claudio Wunder (@ovflowd): https://github.com/nodejs/node/pull/65246#pullrequestreview-4921213372
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/65246#pullrequestreview-4978614004
   ✔  Last GitHub CI successful
   ✘  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/32329790908

@avivkeller avivkeller added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@trivikr trivikr added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Aug 20, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 0ce7b02 into nodejs:main Aug 20, 2026
95 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 0ce7b02

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants