ffi: validate DynamicLibrary getter receivers - #65288
Conversation
|
Review requested:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65288 +/- ##
==========================================
- Coverage 90.32% 90.32% -0.01%
==========================================
Files 751 751
Lines 250000 249972 -28
Branches 47231 47227 -4
==========================================
- Hits 225816 225784 -32
- Misses 15566 15569 +3
- Partials 8618 8619 +1
🚀 New features to boost your workflow:
|
Check the receivers of the path, symbols, and functions getters before unwrapping them. This prevents incompatible receivers from crashing the process and makes the getters throw ERR_INVALID_THIS instead. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol
29be2a9 to
5768e16
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
|
Are we doing this elsewhere? |
Yes. Other native accessors use a V8 Lines 702 to 715 in f83e7df Should we use signature-based approach here instead of explicit |
I posted an alternative PR for the signature-based approach for easy comparison #65415 |
|
I prefer #65415. |
Fixes: #65287
Check the receivers of the path, symbols, and functions getters before unwrapping them. This prevents incompatible receivers from crashing the process and makes the getters throw ERR_INVALID_THIS instead.
Assisted-by: codex:gpt-5.6-sol