Skip to content

ffi: prefer canonical type names - #65417

Open
trivikr wants to merge 1 commit into
nodejs:mainfrom
trivikr:ffi-preferred-aliases
Open

ffi: prefer canonical type names#65417
trivikr wants to merge 1 commit into
nodejs:mainfrom
trivikr:ffi-preferred-aliases

Conversation

@trivikr

@trivikr trivikr commented Aug 20, 2026

Copy link
Copy Markdown
Member

Refs: #64848 (comment)

Document long type names as canonical and use them in examples. Group alternative spellings separately in the documentation and internal type maps while retaining support for every existing alias.


Assisted-by: codex:gpt-5.6-sol

Document long type names as canonical and use them in examples.
Group alternative spellings separately in the documentation and
internal type maps while retaining support for every existing alias.

Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: codex:gpt-5.6-sol
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/ffi

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. ffi Issues and PRs related to experimental Foreign Function Interface support. needs-ci PRs that need a full CI run. labels Aug 20, 2026
@trivikr trivikr added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 77.94118% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.12%. Comparing base (2899539) to head (0ad1dfb).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/ffi/types.cc 41.17% 0 Missing and 10 partials ⚠️
src/ffi/fast.cc 75.00% 0 Missing and 5 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #65417   +/-   ##
=======================================
  Coverage   90.12%   90.12%           
=======================================
  Files         752      752           
  Lines      252282   252327   +45     
  Branches    47442    47448    +6     
=======================================
+ Hits       227360   227420   +60     
+ Misses      16221    16214    -7     
+ Partials     8701     8693    -8     
Files with missing lines Coverage Δ
lib/internal/ffi-shared-buffer.js 55.74% <100.00%> (+0.16%) ⬆️
lib/internal/ffi/fast-api.js 94.50% <100.00%> (+0.02%) ⬆️
src/ffi/fast.cc 68.63% <75.00%> (+0.76%) ⬆️
src/ffi/types.cc 53.72% <41.17%> (-0.10%) ⬇️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. ffi Issues and PRs related to experimental Foreign Function Interface support. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants