Skip to content

fix(skills): remove track-heap-objects from leak hunter workflow #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Cesar-M-Diaz wants to merge 1 commit into from
Closed

fix(skills): remove track-heap-objects from leak hunter workflow #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bundle.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
{
"name": "ns-memory-spike-analysis",
"path": "skills/ns-memory-spike-analysis",
"description": "Analyze memory spikes and suspected leaks via baseline/peak heap sampling, with optional track-heap-objects for retainer analysis",
"description": "Analyze memory spikes and suspected leaks via baseline/peak heap sampling comparison",
"requiresMcp": ["nsolid-console"]
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/core/bundle.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
{
"name": "ns-memory-spike-analysis",
"path": "skills/ns-memory-spike-analysis",
"description": "Analyze memory spikes and suspected leaks via baseline/peak heap sampling, with optional track-heap-objects for retainer analysis",
"description": "Analyze memory spikes and suspected leaks via baseline/peak heap sampling comparison",
"requiresMcp": ["nsolid-console"]
},
{
Expand Down
5 changes: 3 additions & 2 deletions skills/ns-advanced-memory-leak-hunter/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ description: >-

### Phase 3: Capture the Peak / Leak State
1. Once you confirm memory has substantially grown from the baseline, trigger a second analysis.
2. Use advanced `track-heap-objects` only for closure/retainer suspicion; otherwise use `heap-sampling` for 60 seconds. Both require the resolved agent `id`.
2. Capture the peak with `heap-sampling` for 60 seconds. Requires the resolved agent `id`. Do not use `track-heap-objects`: the resulting `heap-profile` asset is not supported by `asset-summary`. When closure/retainer suspicion exists, correlate the peak sample's allocator call stacks with the source using `runtime-code` (Phase 5) instead.
3. Wait for the operation to complete:
```
node "<skill-dir>/wait.cjs" 60
Expand Down Expand Up @@ -100,4 +100,5 @@ description: >-
## Guardrails
- **No early assumptions**: Never declare a memory leak from a single snapshot. Always compare baseline to peak.
- **Reuse what exists**: Do not capture a new baseline or peak sample if the user already supplied the needed assets.
- **Wait times**: Memory tools block the thread. Do not spam endpoints while an asset is in progress.
- **Wait times**: Memory tools block the thread. Do not spam endpoints while an asset is in progress.
- **Unsupported asset types**: `asset-summary` does not support `heap-profile` assets (`track-heap-objects`). Never capture them in this workflow — baseline and peak must always be heap samples.
2 changes: 1 addition & 1 deletion skills/ns-analyze-asset/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ Inspect the summary for these signals:
- Check `events-historic` with the same `app` or agent `id`, plus `start`/`end`, for near-OOM or process-blocked events at the snapshot time.

**Follow-up recommendation:**
- If allocation stack traces are insufficient, recommend advanced `track-heap-objects` via `ns-advanced-memory-leak-hunter`.
- If allocation stack traces are insufficient, recommend a deeper leak hunt (baseline vs peak heap sampling) via `ns-advanced-memory-leak-hunter`.
- For deeper leak hunting workflows, reference the `ns-advanced-memory-leak-hunter` skill.
Comment on lines +76 to 77

@ns-control-tower ns-control-tower Aug 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick

After this edit both bullets now point to ns-advanced-memory-leak-hunter, making the second bullet largely redundant with the first. Consider merging them into one recommendation, or dropping the second bullet entirely.

Suggested change
- If allocation stack traces are insufficient, recommend a deeper leak hunt (baseline vs peak heap sampling) via `ns-advanced-memory-leak-hunter`.
- For deeper leak hunting workflows, reference the `ns-advanced-memory-leak-hunter` skill.
- If allocation stack traces are insufficient, recommend a deeper leak hunt (baseline vs peak heap sampling) via `ns-advanced-memory-leak-hunter`.

(non-blocking — purely a readability tidy)


### 4. Correlate with Runtime Context
Expand Down
Loading