Skip to content

fix Docker build issue #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mptrk merged 2 commits into from
Aug 21, 2026
Merged

fix Docker build issue #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d139838
fix Docker build issue
ytsopokis Aug 20, 2026
0174660
sync devcontainer go version with dockerfile go version
ytsopokis Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "Corteca CLI",
"image": "mcr.microsoft.com/devcontainers/go:1.24",
"image": "mcr.microsoft.com/devcontainers/go:1.25",
"features": {
"ghcr.io/devcontainers/features/docker-in-docker:2": {
"version": "latest",
Expand All @@ -12,7 +12,7 @@
"golangciLintVersion": "latest"
}
},
"postCreateCommand": "sudo apt-get update && sudo apt-get install -y msitools ",
"postCreateCommand": "sudo apt-get update && sudo apt-get install -y msitools",
"customizations": {
"vscode": {
"extensions": [
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ ARG PACKAGE="msix deb rpm osx"
RUN for arch in ${ARCH}; do \
for pkg in ${PACKAGE}; do \
[ $pkg != msix -o $arch == amd64 ] || continue; \
make $pkg GOARCH=$arch || exit 1; \
make $pkg DESTARCH=$arch || exit 1; \
done; \
done

Expand Down
Loading