Skip to content

fix: complete shift scheduling conflict coverage - #7

Merged
nooby6 merged 3 commits into
mainfrom
fix/shift-conflict-test-matrix
Oct 15, 2026
Merged

nooby6 merged 3 commits into
mainfrom
fix/shift-conflict-test-matrix

Conversation

@nooby6

@nooby6 nooby6 commented Oct 15, 2026

Copy link
Copy Markdown
Owner

Summary

  • Reject shift updates that overlap approved employee leave, not just other scheduled shifts.
  • Return a stable 409 EMPLOYEE_INACTIVE response instead of allowing inactive-employee scheduling to surface as a server error.
  • Expand service tests for shift conflicts, approved leave conflicts, inactive employees, invalid windows, adjacent windows, and successful scheduling.

Validation

  • Added targeted unit coverage; GitHub Actions CI will run the full Gradle test suite, including the PostgreSQL concurrency integration test.

Closes #3

@nooby6
nooby6 merged commit 0eac010 into main Oct 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add shift scheduling conflict API and service tests

1 participant