get_day_summary: add include_patterns option - #32
Open
Bhumi701 wants to merge 5 commits into
Open
Conversation
nossa-y
requested changes
Aug 1, 2026
nossa-y
left a comment
Owner
There was a problem hiding this comment.
Scope matches #17 and default-off is byte-identical to main. Before merge:
- Anchor the window to the requested day (end = day's window end, start = end - pattern_days) - right now a past day's summary appends patterns from [now - N, now].
- Make the test assert real content (it's [] on the fixture, so the loop never runs) - with the day anchor it becomes non-empty and clock-independent.
- Put
### Addedunder a## [Unreleased]heading. - Match sibling indentation in TOOLS.
Author
|
Pushed fixes for all 4 review points:
Also merged latest main to pick up the force-push. 106 tests pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17
Adds an optional
include_patternsflag (withpattern_days) toget_day_summarythat appends the same repeated-workflow counts asget_patterns(kind/label/count only, no prose) — so an agent wantingboth no longer needs two tool calls. Defaults to false, so existing
callers see no change.
Scoped per the discussion in the issue thread — no new tool, patterns
stay Tier-1 (measured), and the "main activity in..." sentence-style
summary stays out (that's a salience judgment for the consuming
agent, per SPEC section 7).
Tests: added
test_tool_call_get_day_summary_include_patternsintests/test_mcp.py. Full suite passes (106 tests).
Checklist
pytest -qpasses