feat(sessionize): quantify sessionization debug reasons and cover fli… - #35
Open
Sarcastic-Soul wants to merge 2 commits into
Open
feat(sessionize): quantify sessionization debug reasons and cover fli…#35Sarcastic-Soul wants to merge 2 commits into
Sarcastic-Soul wants to merge 2 commits into
Conversation
…cker/dwell/device boundaries (nossa-y#18)
nossa-y
requested changes
Aug 1, 2026
nossa-y
left a comment
Owner
There was a problem hiding this comment.
Debug-off output is byte-identical - good. But the flicker note quotes the wrong quantity: the SPEC 5.3 gate is B's span (8s on the fixture), the note prints interruption seconds - so it emits "Slack 20s <= 20s", and an A-B-A with a dwell-capped return prints "B 100s <= 20s", which is false. Your PR body's own example ("8s <= 20s") is the correct output.
- Compare wall_seconds() in the note; update tests to cover span != active.
- Add a device-boundary test (SPEC 5.5, see test_multidevice.py).
- Only emit the device note when the window spans >1 device - as-is every entry on a single-monitor DB gets "; device: monitor_1".
- Drop Segment.device - written, never read.
…e notes to multi-monitor contexts
nossa-y
force-pushed
the
main
branch
3 times, most recently
from
August 6, 2026 18:51
972b4d9 to
e92e599
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Closes #18.
Summary
Extends the sessionization debug info (
_debugblock emitted when--debug/debug=Trueis enabled) with quantified reason strings and coverage for deterministic boundaries (§5):session_gap: Formatted with measured gap against §5.2 threshold (session_gap: 3600s > 300s).merged flicker: Notes folded interruptions and their span vs §5.3 limit (merged flicker: Slack 8s <= 20s).dwell capped: Notes when frame active time is capped at §5.1 limit (dwell capped: 90s).device: Notes when frames are partitioned by monitor device (device: Display 1).Remains Tier-1: measured, reproducible, namespaced under
_debug, opt-in via--debug, and byte-identical when off.Checklist
pytest -qpasses