Make step text opt-in - #47
Draft
kanishkpaul wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Makes typed and pasted content opt-in in the one-shot replay path. It also aligns
get_stepswithget_activitydefaults, lets callers reuse a custommin_minutesselection, and orders replay events by timestamp.Why
The README promises output-level content opt-in, but
get_stepspreviously returned captured text by default. It also rebuilt a different default time window fromget_activity, which made a frame id harder to reproduce.User impact
include_text: trueor--include-textto request capped typed/pasted content.get_stepsandaframes stepsnow default to a two-hour lookback and acceptmin_minutes/--min-minutesfor a matching selection.--no-textflag remains accepted.Deferred
This is intentionally a compatibility-focused first fix. Exact multi-monitor event provenance, opaque stable frame references, and guarded workflow execution need a separate schema/design change.
Validation
pytest -q(108 passed)python -m build --sdist --wheelChecklist
pytest -qpasses