chore: sync generated client with API - #57
Merged
Conversation
|
| Filename | Overview |
|---|---|
| internal/api/client.gen.go | Regenerates the API surface with managed-auth models and operations plus additive schema updates; checked client operation signatures remain compatible with existing callers. |
| internal/cmd/sessionstart_flags.gen.go | Correctly maps the two new managed-auth flags into optional API fields, but no tests cover their serialization semantics. |
Prompt To Fix All With AI
### Issue 1
internal/cmd/sessionstart_flags.gen.go:99-104
**Managed-auth flags lack coverage**
The new `AuthIds` and `WaitForAuthentication` mappings have no tests confirming repeatable ID handling or the distinction between an omitted boolean and explicit false, leaving future generator regressions in these request semantics undetected.
- Add a comment if the PR does n... ([source](https://app.greptile.com/review/custom-context?memory=instruction-0))
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "chore: sync generated client with API" | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
go test ./...make check(run after commit)