feat: namespace install-script approval commands under npm install-scripts (#9629)#9634
Closed
owlstronaut wants to merge 1 commit into
Closed
feat: namespace install-script approval commands under npm install-scripts (#9629)#9634owlstronaut wants to merge 1 commit into
owlstronaut wants to merge 1 commit into
Conversation
…ripts (#9629) Add a namespaced `npm install-scripts` command that groups the install-script approval operations, following npm's existing `npm cache <cmd>` / `npm token <cmd>` convention: - `npm install-scripts approve <pkg>... | --all` - `npm install-scripts deny <pkg>... | --all` - `npm install-scripts ls` (list packages with unreviewed install scripts) The shipped `npm approve-scripts` and `npm deny-scripts` commands keep working as aliases for `approve` and `deny`, so this is additive and backwards compatible. The shared `AllowScriptsCmd` base now dispatches through `runMode(mode, args)`; the standalone commands route through it via `static verb`. The `--allow-scripts-pending` flag is only honored by the commands that declare it, so the namespace lists exclusively through `ls`. Closes #9545 Follow-up from RFC npm/rfcs#868. (cherry picked from commit 0c4dd41)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #9629 to
release/v11.The automated backport failed to cherry-pick cleanly (conflicts in
lib/commands/rebuild.jsand thenpm.js/smoke-tests usage snapshots). Resolved manually:npm install-scriptscommand rename +npm install-scripts lsremediation from feat: namespace install-script approval commands under npm install-scripts #9629.shrinkwrap/star/stars/unstarand nopatch) withinstall-scriptsinserted, verified against npm's usage wrap formatter at every column width.Closes #9545 on the v11 line.
Follow-up from RFC npm/rfcs#868.