Robustness fixes: logging, dependency, packaging, chart batching - #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
print()calls with theloggingmodule across content extraction, formatters, updaters, and elements. The intentional user-facing display output (SlidePrinter/TablePrinter, used bylist_content()/show_data()) is untouched — those are meant to print.Pillowas an explicit dependency:adders/image_adder.pyimportsPILdirectly, but it was only ever satisfied transitively throughpython-pptx. Pinning it directly avoids a future break if that transitive dependency ever changes.py.typedmarker (and thepackage-dataentry needed to ship it in the wheel) so downstream consumers' type checkers actually pick up this package's type hints. Verified the built wheel includes it.Deck.update_chartpreviously calledchart.update_series()per series (each doing a fullreplace_data) and thenchart.save_changes()again — N+1 full chart XML rewrites for N series. AddedDeckChart.update()to merge categories/series and apply once;Deck.update_chartnow uses it.update_series/update_categoriesare unchanged for direct/individual use.remove_text/remove_chart/remove_tableinDeckSlide, which were copy-pasted apart from the getter and error label, into one_remove_elementhelper. Error messages are unchanged.No version bump — this is not a release yet.
Test plan
pytest -q— 33 passedmypy --ignore-missing-imports src/deckflow— no issuespy.typedand thePillowrequirement are present in the artifact