Repository navigation
Conversation
Every interactive client sends interrupt, and getting it wrong leaves CIDER without a prompt, Calva with a result that never comes and Conjure (which never sends interrupt-id) with an eval that keeps running. The new checks interrupt a sleep snippet, with and without interrupt-id, and look at what follows: the session, evals that were waiting for it and interrupts from another connection. nREPL 1.8.0 and Babashka drop the evals that were waiting (nrepl#503) and send the interrupted eval's done to the interrupt's connection (nrepl#498), so they fail two of them. proof serve now stops an interrupted eval the way dialtone and repartee do, and has those bugs, along with the exception nREPL sends after the done (nrepl#506), as scenarios that -like clojure and -like babashka turn on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
proof servenow stops an interrupted eval, and nREPL 1.8.0's interrupt bugs are scenarios that-like clojureand-like babashkaturn on, so a client's tests see what its users see. There's no check for the race in nrepl/nrepl#504, as nothing hits it reliably.