Skip to content

test: make test names and cases consistent #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
himura467 merged 1 commit into from
Oct 28, 2026
Merged

test: make test names and cases consistent #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions test/spec_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
Nack::Spec.valid_header_value?(:a).must_equal false
end

it "accepts final statuses in 200..599 or 101" do
it "accepts final statuses" do
Nack::Spec.valid_status?(101).must_equal true
Nack::Spec.valid_status?(200).must_equal true
Nack::Spec.valid_status?(599).must_equal true
Expand All @@ -49,7 +49,7 @@
Nack::Spec.valid_content_length?("").must_equal false
Nack::Spec.valid_content_length?("0\n0").must_equal false
Nack::Spec.valid_content_length?("\xff").must_equal false
Nack::Spec.valid_content_length?(0).must_equal false
Nack::Spec.valid_content_length?(:a).must_equal false
end

it "knows which responses carry no entity body" do
Expand All @@ -60,12 +60,12 @@
Nack::Spec.no_entity_body?(199, get).must_equal true
Nack::Spec.no_entity_body?(204, get).must_equal true
Nack::Spec.no_entity_body?(304, get).must_equal true
Nack::Spec.no_entity_body?(200, head).must_equal true
Nack::Spec.no_entity_body?(101, get).must_equal false
Nack::Spec.no_entity_body?(200, get).must_equal false
Nack::Spec.no_entity_body?(200, head).must_equal true
end

it "accepts interim statuses in 100..199 other than 101" do
it "accepts interim statuses" do
Nack::Spec.valid_interim_status?(100).must_equal true
Nack::Spec.valid_interim_status?(199).must_equal true
Nack::Spec.valid_interim_status?(99).must_equal false
Expand Down
2 changes: 1 addition & 1 deletion test/spec_utils.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
pairs.must_equal [["b", "2"]]
end

it "measures body size in bytes" do
it "measures a body in bytes" do
Nack::Utils.body_bytesize(nil).must_equal 0
Nack::Utils.body_bytesize("é").must_equal 2
Nack::Utils.body_bytesize(IO::Buffer.for("é")).must_equal 2
Expand Down
Loading