Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -100,15 +100,15 @@ This PR delivers strong, well-structured documentation that significantly exceed

### Summary of Deductions

| Category | Deduction | Reason |
| Category | Deduction | Reason |
| ---------------------------------- | --------- | --------------------------------------------------------------------- | --- | -------------------------------- |
| Missing troubleshooting/error docs | -5 | No guidance on common failure modes |
| Missing prerequisites | -2 | No runner/dependency requirements noted |
| Incomplete edge-case docs | -4 | maxdepth 2 limit, root-path sync naming, never-deletes implications |
| env-vars behavior mismatch | -2 | README implies compose-level injection, script does GITHUB_ENV export |
| auth-type values underdocumented | -2 | No explanation of what each auth type requires |
| Missing function docstrings | -2 | `discover_compose_files` and `export_env_vars` lack docstrings |
| Minor inline comment gaps | -1 | ` | | true`on curl,`sort -z` rationale |
| Missing troubleshooting/error docs | -5 | No guidance on common failure modes |
| Missing prerequisites | -2 | No runner/dependency requirements noted |
| Incomplete edge-case docs | -4 | maxdepth 2 limit, root-path sync naming, never-deletes implications |
| env-vars behavior mismatch | -2 | README implies compose-level injection, script does GITHUB_ENV export |
| auth-type values underdocumented | -2 | No explanation of what each auth type requires |
| Missing function docstrings | -2 | `discover_compose_files` and `export_env_vars` lack docstrings |
| Minor inline comment gaps | -1 | ` | | true`on curl,`sort -z` rationale |

## References

Expand Down
2 changes: 1 addition & 1 deletion .github/actions/1password-secret-sync/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ runs:
steps:
- name: Install 1Password CLI
# Pin to commit SHA for supply chain security — update when action changes
uses: 1password/install-cli-action@9a0c9dd934086b7ab1d90115d455bda1c53c2bdb # v2.0.2
uses: 1password/install-cli-action@a5215d3a7f75c1629216c465ea9ab3ab399c4b71 # v4.0.0

- name: Sync secrets
id: sync
Expand Down
3 changes: 1 addition & 2 deletions pages/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -319,8 +319,7 @@ <h2>Detailed setup walkthrough</h2>
</p>
<pre>
cp pages/index.html docs/index.html
# Settings → Pages → Source: GitHub Actions (or branch /docs)</pre
>
# Settings → Pages → Source: GitHub Actions (or branch /docs)</pre>
<p>
Then use <code>https://&lt;your-org&gt;.github.io/&lt;repo&gt;/</code> as the redirect. Any
other HTTPS static host (Vercel, Netlify, etc.) works equally well.
Expand Down
Loading