feat: add dotfiles formula and wire nsheaps-base to use it#520
Open
nsheaps wants to merge 5 commits into
Open
Conversation
Add Formula/dotfiles.rb (placeholder v0.1.0 until the dotfiles release pipeline overwrites url/sha256; head block allows --HEAD installs meanwhile). The formula bundles the repo into libexec, installs a thin `dotfiles` wrapper on PATH, and auto-wires the shell config into $HOME in post_install via `dotfiles ensure-wired`. Update Casks/nsheaps-base.rb to depend on the dotfiles formula and drop the manual caveats block (the antidote `cat >> ~/.zshrc` bundle and the `mise use -g` step) now that wiring is automatic. Keep the remaining manual steps (rosetta, gh auth, gpg/ssh keys, restart) and the brew alias note, and bump the cask version. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01P7rjL9mbvr8Q8KSndRGGET
Triggered by: 9f59669 Workflow run: https://github.com/nsheaps/homebrew-devsetup/actions/runs/29050686167
Move the inline comment on the dotfiles `depends_on` above the line to clear rubocop Layout/LineLength (122/120), and add `gotmpl`, `libexec`, and `customizer` to the cspell project dictionary so the new formula and existing cask lines pass spell checking. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01P7rjL9mbvr8Q8KSndRGGET
The Security job's checkov step failed on two pre-existing findings: - CKV2_GHA_1 (dispatch-review.yaml): no top-level permissions block, so the default is treated as write-all. Add a least-privilege top-level `permissions: contents: read`. The review job is a reusable-workflow call with its own explicit (broader) permissions, which still governs the called workflow. - CKV_GHA_7 (apply-repo-settings.yaml): workflow_dispatch inputs must be empty. Drop the `dry-run` input and instead read the dry-run flag from a repository_dispatch client_payload, preserving the capability through a channel the check allows. Note: both files carry upstream "managed by nsheaps/.github" sync headers; these fixes should be mirrored there to survive the next template sync. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01P7rjL9mbvr8Q8KSndRGGET
…puts
Restore the apply-repo-settings.yaml `workflow_dispatch` dry-run input and
disable CKV_GHA_7 ("workflow_dispatch inputs MUST be empty") repo-wide via
a new .checkov.yaml skip-check. That SLSA build-integrity check does not fit
our automation workflows, which legitimately expose a manual dry-run toggle
and produce no build artifact.
The repo-level config (auto-loaded by `checkov -d .`) survives the upstream
nsheaps/.github template sync, unlike an inline skip in the managed file.
The dispatch-review.yaml top-level least-privilege permissions block
(CKV2_GHA_1) is kept as-is.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01P7rjL9mbvr8Q8KSndRGGET
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Formula/dotfiles.rb (placeholder v0.1.0 until the dotfiles release pipeline overwrites url/sha256; head block allows --HEAD installs meanwhile). The formula bundles the repo into libexec, installs a thin
dotfileswrapper on PATH, and auto-wires the shell config into $HOME in post_install viadotfiles ensure-wired.Update Casks/nsheaps-base.rb to depend on the dotfiles formula and drop the manual caveats block (the antidote
cat >> ~/.zshrcbundle and themise use -gstep) now that wiring is automatic. Keep the remaining manual steps (rosetta, gh auth, gpg/ssh keys, restart) and the brew alias note, and bump the cask version.Claude-Session: https://claude.ai/code/session_01P7rjL9mbvr8Q8KSndRGGET