fix: allow exact Chrome Web Store release version - #80
Merged
Conversation
Collaborator
Author
|
Re-reviewed PR 80. No regression issues found.\n\nChecked behavior:\n- exact target version works (tested |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the Chrome Web Store release workflow when the repository version is behind the already-published store version.
The Chrome Web Store currently has
1.2.0, butmainstill has1.1.4. The existing workflow could only bump from the repository version:patch->1.1.5, still lower than Chrome Web Storeminor->1.2.0, equal to Chrome Web Store and not uploadablemajor->2.0.0, too large for this releaseChanges
target_versionworkflow input for exact release versions, e.g.1.2.1.patch/minor/majorbehavior whentarget_versionis empty.scripts/bump-version.jsto accept either a bump type or an exactx.y.zversion.manifest.template.jsonpackage.jsonpackage-lock.jsonRelease Instructions
After this PR is merged, run Release to Chrome Web Store manually with:
version_type:patch(ignored whentarget_versionis set)target_version:1.2.1This will generate and upload extension version
1.2.1without requiring an incorrect major bump.Verification
1.2.1in a temporary directorypatchbump still worksnpm run lintnpx tsc --noEmitOAUTH_CLIENT_ID=test-client-id EXTENSION_KEY=test-extension-key npm run generate-manifest && npm run build