Repository navigation
tests: rstest fixtures for the NAR tree and the iets home - #232
Merged
Merged
Conversation
fixture_tree() built its tree under the shared temp dir, named by pid and a tag every caller had to keep unique, and never removed it. As an rstest fixture each test gets its own TempDir, dropped at the end. Change-Id: Ia860f1d3fea5c648833551e0e99ed6e6118ad9e8
hermetic::iets() picked the home from the thread name, so a run from a thread the test spawned got a shared pid-named home, and homes were left in the target dir. The bin fixture owns a TempDir home for the test. The e2e Store and the cache_semantics Work own one too. Change-Id: I7e45e9a1341f0db401f365a8bca8885286e25bb9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #231.
tree: Tree: the NAR fixture tree in its own TempDir, without pid+tag dirs.bin: Iets: iets with a TempDir home per test, without the thread-name lookup.