Repository navigation
build: do not call a build the store stopped a success - #235
Merged
Merged
Conversation
With keep-going off, the daemon stops the other builds when one fails, and it names only the failed one. The end of a stopped build's activity looks like the end of a build that succeeded, so the progress display showed it with a ✔. When a batch has a failure, ask the store for the outputs of the builds held for a verdict. A build with an output the store lacks now shows as stopped, and the summary counts it apart. Fixes #228 Assisted-by: Claude Code (claude-opus-5) Change-Id: I3fdc7360b728b79f0d5019cbfd9253dd7330ed72
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #228.
With keep-going off, the daemon stops the other builds when one fails, and it names only the failed one. The progress display took the end of a stopped build's activity as a success, and showed it with a ✔.
When a batch has a failure, the dispatcher now asks the store for the outputs of the builds held for a verdict. A build with an output the store lacks shows as
· <name> stopped after <t> (an output is not in the store), and the summary counts it apart:summary: ✔ 1 succeeded · ✘ 2 failed · 1 stopped. A batch with no failure makes no extra store query.Tests:
a_dependency_the_store_stopped_is_not_a_successfails without the fix (it shows✔ cut). fmt, clippy and the full test suite pass.