Repository navigation
api: make the four longest concurrent eval delays smaller - #240
Merged
Merged
Conversation
fn-identity, lint-speculated, lint-demanded and drv-speculated waited on slow 2000000 or 3000000, and took 5 to 7 s each with 8 workers on an idle builder. On a loaded farm builder the test took 89 to 263 s, and it went past the 300 s limit in 3 of the last 11 builds. 300000 gives the helpers the same time to run ahead as in the route and ahead cases. The test takes 3.2 s on bld1, down from 7.3 s. Assisted-by: Claude Code (claude-opus-5) Change-Id: I74a3e9aaba63d4f3fd7eb5b99f131850f57a47f1
zimbatm
enabled auto-merge
October 24, 2026 01:15
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
concurrent_eval_matches_sequential_evaltook 89 to 263 s on the farm builders. It went past the 300 s nextest limit in builds 623, 627 and 628, so #236 and #237 left the merge queue.Four cases still waited on
slow 2000000orslow 3000000: fn-identity, lint-speculated, lint-demanded and drv-speculated. They took 5 to 7 s each on an idle bld1. This PR sets them to 300000, the value that the route and ahead cases use (see #233).On bld1 the test takes 3.2 s (it took 7.3 s before), and 19 s on 2 CPUs. It passed in 5 of 5 runs. No test or case is removed, and no timeout changes.