[17.0][FIX] ptplus_partner: guard the 17.0 column rename with column_exists - #4
Closed
eantones wants to merge 5 commits into
Closed
[17.0][FIX] ptplus_partner: guard the 17.0 column rename with column_exists#4eantones wants to merge 5 commits into
eantones wants to merge 5 commits into
Conversation
The 17.0.4.0.2 pre-migration renames res_partner.legal_name behind a registry-membership check only (and the check is inverted relative to when the rename is safe: at ptplus_partner's own pre-migration nothing defines l10n_pt_legal_name yet, so the guard always fires). On databases where the target column already exists, rename_fields dies with DuplicateColumn and kills the whole upgrade. Add a column_exists guard so the rename only runs when the target column is still absent, and use the 'not in' comparison form. Same fix as the 16.0 scripts (16.0.4.0.1/16.0.4.0.2).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 17.0.4.0.2 pre-migration renames
res_partner.legal_namebehind a registry-membership check only (inverted relative to when the rename is safe: at ptplus_partner's own pre-migration nothing definesl10n_pt_legal_nameyet, so the guard always fires). On databases where the target column already exists,rename_fieldsdies withDuplicateColumnand kills the whole upgrade.Add a
column_existsguard so the rename only runs when the target column is still absent. Same fix as the 16.0 scripts (PR #3).Replaces the aggregate-time sed previously carried in our deployment config — policy: every code change is a published PR, never an aggregate-time mutation. To be reported to the vendor (Exo) as well.
Note: the vendor mirror is bot-published with force-pushed orphan snapshots per release — when exo 17.0 head moves past
400562b, rebase this branch onto the new snapshot (rebase operativa).