Repository navigation
fix(node): require Node 24.22.1 and drop the devcontainer - #20
Merged
Merged
Conversation
The publicly disclosed eMudhra intermediate CA key compromise is fixed in Node 24.22.1 (nodejs/node#66871). Pinning the exact version in .nvmrc and devEngines, and a floor in engines, keeps local, CI and docs from running a release that still trusts the compromised CA.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Public eMudhra CA compromise (October 2026): Node.js fixed it in nodejs/node#66871, shipped in 22.23.4 / 24.22.1 / 26.12.1 on 2026-10-21. This repo pinned Node 24.13.0, which predates the fix.
Changes
.nvmrcanddevEngines.runtime.version: 24.13.0 -> 24.22.1engines.node:>=24.13.0->>=24.22.1 <25pnpm-lock.yamlregenerated (records the node runtime)AGENTS.md,MIGRATE_TO_BUN.md: version references updatednode-version-file: package.json, so it picks up the new pin; no Actions lines changed.devcontainerdirectory was already removed on main; no references remainVercel
On Vercel,
enginesonly selects the major version and Vercel picks the patch. The Vercel project's Node.js Version setting should be set to 24.x.Validation (pnpm)
pnpm install: ok (node 24.22.1)pnpm typecheck: 15/15 okSKIP_ENV_VALIDATION=1 pnpm build: 7/7 ok (plain build fails on missing env vars, as on main)pnpm lint: fails in db/redis/ui/storybook-config/web on oxlint anti-slop rules; same on mainpnpm test:ci: web tests need a container runtime, unavailable locally; same on main