Skip to content

Fix Git Registry Installations#134

Merged
fdncred merged 3 commits into
nushell:mainfrom
neurolag:fix-git-registry
Jul 7, 2026
Merged

Fix Git Registry Installations#134
fdncred merged 3 commits into
nushell:mainfrom
neurolag:fix-git-registry

Conversation

@neurolag

@neurolag neurolag commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

As mentioned in #133, an inverted assertion causes all installations of git packages from registries to fail.

Description

Changes made in this commit add a test to proof this error and gets rid of the incorrect assertion.
Merging this PR will fix #108 and fix #133

@neurolag neurolag force-pushed the fix-git-registry branch from c25f588 to cd314ce Compare July 7, 2026 22:22
@fdncred

fdncred commented Jul 7, 2026

Copy link
Copy Markdown

what's the point of spam_git?

@neurolag

neurolag commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

It's for reproducing issue #133
If you check out commit 9da6413 and run the tests, you'll notice that the test which installs spam_git won't work.

After commit cb1e008, which fixes the issue, the test will work.

@fdncred fdncred merged commit dc61b38 into nushell:main Jul 7, 2026
3 checks passed
@fdncred

fdncred commented Jul 7, 2026

Copy link
Copy Markdown

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

git Packages in Registries Won't Install Can't install nu-git-manager

2 participants