Migrate to New Commands#136
Open
neurolag wants to merge 2 commits into
Open
Conversation
Changes made in this commit will fix nushell#132
|
I think you'll have to bump the ci to use 114 first |
Contributor
Author
|
I'll do it tomorrow |
Contributor
Author
|
Huh... now that's strange I'll work on it next week! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In nushell/nushell#18364,
str downcasehas been deprecated in favor ofstr lowercase.Changes made in this PR will change the code accordingly and thus fix #132.
This PR will, however, break support for nushell v0.113, as the
str lowercasecommand doesn't exist before nushell v0.114.0.