Skip to content

🚨 unwelcome pr from bot 🚨 - #859

Closed
alectimison-maker wants to merge 1 commit into
nuxt-modules:mainfrom
alectimison-maker:fix/prerender-ignore
Closed

🚨 unwelcome pr from bot 🚨#859
alectimison-maker wants to merge 1 commit into
nuxt-modules:mainfrom
alectimison-maker:fix/prerender-ignore

Conversation

@alectimison-maker

Copy link
Copy Markdown

Summary

Respect htmlValidator.ignore while validating prerendered routes.

Fixes #768.

Changes

  • reuse the existing isIgnored matcher in the production prerender:generate hook
  • add a Nuxt prerender regression fixture for an ignored invalid page
  • keep validation coverage for non-ignored and redirect pages

Validation

  • pnpm vitest run test/module-prerender.test.ts (3 passed)
  • pnpm test (24 passed, 1 todo, 1 skipped file)
  • pnpm lint
  • pnpm build
  • git diff --check

@netlify

netlify Bot commented Aug 5, 2026

Copy link
Copy Markdown

Deploy Preview for html-validator ready!

Name Link
🔨 Latest commit 2fd4214
🔍 Latest deploy log https://app.netlify.com/projects/html-validator/deploys/6a72e3e7cce5d600085c0544
😎 Deploy Preview https://deploy-preview-859--html-validator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

❌ Automation signals

Activity patterns show signs of automation.

View full analysis →

🚩 Report this account →

Evidence
  • Fork spike detected: Burst of 9 fork events in a single 24-hour window
  • High PR volume (weekly): 50 PRs in the last 7 days
  • Rapid fork→PR pattern: 48/49 fork branches followed by upstream PRs within 88s

Last 5 PRs:

This is an automated analysis by AgentScan

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

We've flagged this as a potential contribution without a human behind it. We welcome the thoughtful use of AI tools when contributing, but ask all contributors to follow two core principles:

  1. Never let an LLM speak for you - all comments, issues, and PR descriptions should be written in your own words, reflecting your own understanding.
  2. Never let an LLM think for you - only submit contributions you fully understand and can explain.

Please review these AI-assisted contribution guidelines and update this contribution if needed.

We're closing this for now as the account looks automated. If we got that wrong, please just reopen the PR and we'll take another look.

@github-actions github-actions Bot changed the title fix: respect ignore during prerender 🚨 unwelcome pr from bot 🚨 Aug 5, 2026
@github-actions github-actions Bot closed this Aug 5, 2026
@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.04%. Comparing base (11cdf36) to head (2fd4214).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #859      +/-   ##
==========================================
+ Coverage   55.05%   56.04%   +0.98%     
==========================================
  Files           4        4              
  Lines          89       91       +2     
  Branches       29       34       +5     
==========================================
+ Hits           49       51       +2     
  Misses         40       40              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ignore option being ignored when prerendering

1 participant