Skip to content

[4.6.0] fix: include SDK root in local CMake prefixes - #240

Merged
wyli merged 1 commit into
release/4.6.0from
fix/release-4.6-sdk-cmake-prefix
Sep 4, 2026
Merged

[4.6.0] fix: include SDK root in local CMake prefixes#240
wyli merged 1 commit into
release/4.6.0from
fix/release-4.6-sdk-cmake-prefix

Conversation

@wyli

@wyli wyli commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Bug use case

With the Holoscan SDK installed at its default /opt/nvidia/holoscan prefix, a standalone C++ Module that uses find_package(holoscan) can fail during either of these local workflows:

holoscan build <module> --local
holoscan package <module> --local

The 4.6 CLI passes /opt/nvidia/holoscan/lib as the CMake installation prefix. That starts CMake's package search one level too deep, so it may not discover the SDK configuration under <prefix>/lib/cmake/holoscan.

Fix

  • Pass the SDK root first in CMAKE_PREFIX_PATH.
  • Retain <sdk-root>/lib as a secondary compatibility prefix.
  • Share the same prefix construction between local build and package paths, matching the behavior on main.

Validation

  • Existing focused unit tests: 46 passed.
  • Built a generated standalone C++ Module locally against Holoscan SDK 4.6.0.
  • Packaged the generated Module locally as a DEB.

No unit tests were added.

AI-assisted: Created with Codex/GPT at the user's request.

Co-authored-by: Codex <noreply@openai.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@wyli
wyli requested review from jcfr and tbirdso September 4, 2026 16:02

@tbirdso tbirdso left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wyli is this a cherry-pick of an existing commit? Could you provide the origin reference?

@wyli

wyli commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator Author

@wyli is this a cherry-pick of an existing commit? Could you provide the origin reference?

the fix is part of a large new feature commit 655a34b, not feasible to directly cherrypick

@wyli
wyli merged commit f509cfb into release/4.6.0 Sep 4, 2026
30 checks passed
@wyli
wyli deleted the fix/release-4.6-sdk-cmake-prefix branch September 4, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants