Skip to content

[fix] Support CMake 3.22 - #22

Merged
vikuznetsov-nvidia merged 1 commit into
mainfrom
vikuznetsov/support-cmake-3-22
Sep 17, 2026
Merged

vikuznetsov-nvidia merged 1 commit into
mainfrom
vikuznetsov/support-cmake-3-22

Conversation

@vikuznetsov-nvidia

@vikuznetsov-nvidia vikuznetsov-nvidia commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • New Features

    • Added support for building with CMake 3.22 and newer.
  • Bug Fixes

    • Improved compatibility with CMake’s standard content-fetching behavior.
  • Documentation

    • Updated prerequisites, quick-start guides, and installation instructions to reflect the CMake 3.22 minimum requirement.
  • Chores

    • Simplified the container build setup by using Ubuntu’s bundled CMake package.

Signed-off-by: Victor Kuznetsov <vikuznetsov@nvidia.com>
@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Enterprise

Run ID: cd216e5e-a261-47a2-9e0f-627805f3e2dc

📥 Commits

Reviewing files that changed from the base of the PR and between 7211832 and 06198ad.

📒 Files selected for processing (12)
  • AGENTS.md
  • CMakeLists.txt
  • README.md
  • cmake/AddCUDSS.cmake
  • cmake/AddSpdlog.cmake
  • docs/sphinx/installation.rst
  • docs/sphinx/pycunls_installation.rst
  • docs/sphinx/quick_start.rst
  • examples/CMakeLists.txt
  • python/CMakeLists.txt
  • scripts/Dockerfile
  • tests/install_test/CMakeLists.txt
💤 Files with no reviewable changes (3)
  • python/CMakeLists.txt
  • cmake/AddCUDSS.cmake
  • cmake/AddSpdlog.cmake

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

The project now requires CMake 3.22 instead of 3.24. FetchContent extraction settings use CMP0135 when available, and explicit timestamp options are removed. Docker installation and repository documentation reflect these changes.

Changes

CMake compatibility update

Layer / File(s) Summary
Minimum CMake version and build environment
CMakeLists.txt, README.md, docs/sphinx/*, examples/CMakeLists.txt, tests/install_test/CMakeLists.txt, AGENTS.md, scripts/Dockerfile
The minimum CMake version changes from 3.24 to 3.22 across build files and documentation. The Dockerfile uses Ubuntu’s distribution CMake package instead of the Kitware APT repository.
FetchContent extraction settings
CMakeLists.txt, cmake/AddCUDSS.cmake, cmake/AddSpdlog.cmake, python/CMakeLists.txt
Explicit DOWNLOAD_EXTRACT_TIMESTAMP TRUE options are removed from dependency declarations. Policy CMP0135 is set to NEW when available.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: alexkorovko

Merge Risk: ⚪ Minimal · up to 06198

The CMake 3.22 compatibility changes have no established merge-blocking risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: adding support for CMake 3.22. This matches the version changes across the build configuration, documentation, and Dockerfile.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch vikuznetsov/support-cmake-3-22

Comment @coderabbitai help to get the list of available commands.

@vikuznetsov-nvidia
vikuznetsov-nvidia merged commit 35a3c62 into main Sep 17, 2026
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant