Skip to content

CUST-5373: add event resource models - #766

Merged
AaronDDM merged 1 commit into
mainfrom
fix/cust-5373-event-resources
Oct 13, 2026
Merged

AaronDDM merged 1 commit into
mainfrom
fix/cust-5373-event-resources

Conversation

@AaronDDM

@AaronDDM AaronDDM commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

TypeScript consumers cannot include or read resources on event models even though the API client already preserves the field. This adds typed room and equipment booking support to Event, CreateEventRequest, and UpdateEventRequest.

  • Export EventResource with required email and optional name, capacity, building, and floor fields.
  • Keep resource emails required in update requests while retaining the existing partial types for other event fields.
  • Add six regression tests through the real SDK serialization/deserialization path with mocked HTTP, covering create/update/find/list, nested field casing, email-only entries, omitted resources, and empty-array clearing. Compile-time assertions protect required emails and numeric floor numbers.
  • Add an Unreleased changelog entry.

Validation: all 495 tests across 31 suites pass with coverage; CommonJS and ESM builds, lint, formatting, and diff checks pass. The regression suite fails on unmodified main with the missing resource type/field errors.

CI note: the existing documentation workflow fails during job setup because GitHub cannot resolve cloudflare/pages-action. This happens before the changed code runs; see the failed documentation job.

Jira: CUST-5373, remaining Node.js work under CUST-5262.

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@qasim-nylas qasim-nylas left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@qasim-nylas qasim-nylas left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@AaronDDM
AaronDDM requested a review from radenkovic October 13, 2026 15:43
@codecov

codecov Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.75%. Comparing base (fabe2d6) to head (2f1b1bb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #766   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files          43       43           
  Lines        1041     1041           
  Branches       90       90           
=======================================
  Hits         1028     1028           
  Misses         12       12           
  Partials        1        1           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AaronDDM
AaronDDM merged commit e34eb1f into main Oct 13, 2026
9 of 10 checks passed

This branch had an error being deployed

1 failed deployment
sdk-reference — 2f1b1bbf Deployed Oct 13, 2026 by AaronDDM via docs #750
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants