Conversation
Connector findings were losing description, synopsis and a number of other scanner-provided fields because neither the SDK Finding contract nor the jobs_registry Vulnerability model carried them, and the worker explicitly dropped matched_at. - worker: map description, synopsis, authors, affectedUrl (from matched_at), ports, vpr_score, bid/cea/iava, publication/modification dates and confidence onto the jobs_registry Vulnerability - proto: add confidence to Vulnerability and mirror the new connector Finding fields; regenerate the Go stubs - core-api: add a nullable confidence column with a migration, and refresh every scanner-derived column on re-scan so rows created before this change are backfilled instead of staying empty
The detail page never rendered solution, and several API fields (synopsis, host, confidence, CEA/IAVA ids, authors, extractor output, dates) were missing. EPSS/VPR/CVE/BID/CWE were also nested under the cvssMetric guard, so they disappeared whenever no CVSS vector was present. - add a Solution section and a Details section (authors, extractor, dates, extracted results); show synopsis, host, confidence, CEA and IAVA - move EPSS/VPR/CVE/BID/CWE out of the cvssMetric conditional - add htmlToPlainText() and use it for description/synopsis/solution so scanner HTML renders as readable text without injecting raw HTML - regenerate the API client for the new confidence field
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+27
to
+29
| const text = input | ||
| .replace(BLOCK_BOUNDARY, '\n') | ||
| .replace(ANY_TAG, '') |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for Vercel as a new integration and target source in the system. The changes include defining the Vercel integration schema, registering the connector, updating the integration catalog, and providing comprehensive tests (including end-to-end tests) to ensure correct behavior. Additionally, user-facing labels and icons for Vercel are integrated throughout the codebase.
Vercel Integration Support
vercelSchemafor Vercel integration, including required fields (apiToken, optionalteamId), and registered theVercelConnectorso it can be resolved by the integration factory. ([core-api/src/modules/integrations/schemas/vercel.schema.tsR1-R39](https://github.com/oasm-platform/open-asm/pull/641/files#diff-ccf2cef214466f69ac76a5fc638476ba1d2b471c9dadda5870ce459c88632537R1-R39))vercelSchemato theuniversalIntegrationSchemaunion, making Vercel available in the integration catalog. ([[1]](https://github.com/oasm-platform/open-asm/pull/641/files#diff-4b5f56ab31ab13b7aa358641337f6854bb1d20da40b40f58bb0e94e13e7758d4R6),[[2]](https://github.com/oasm-platform/open-asm/pull/641/files#diff-4b5f56ab31ab13b7aa358641337f6854bb1d20da40b40f58bb0e94e13e7758d4R32))Testing and Validation
[core-api/src/modules/integrations/schemas/vercel.schema.spec.tsR1-R71](https://github.com/oasm-platform/open-asm/pull/641/files#diff-1ce6fddfaa2b546ce2475b87171cf318ac83e5f00040dfc7b6fbca3686f95a48R1-R71))vercel-e2e.spec.ts) to verify the full integration pipeline, including dry-run, error handling, ingestion, and catalog exposure. ([core-api/src/modules/integrations/vercel-e2e.spec.tsR1-R329](https://github.com/oasm-platform/open-asm/pull/641/files#diff-7946aa7d4d4da972b23771396e97270a59e3d4b0dd5d6cde2066b62051439186R1-R329))Target Source Enhancements
VERCELas a new value in theTargetSourceenum to represent Vercel-originated targets. ([core-api/src/modules/targets/entities/target.entity.tsR40](https://github.com/oasm-platform/open-asm/pull/641/files#diff-21f460d0904ed00547170e63325bba1773ec246f53d78692821e626d21bdca43R40))[[1]](https://github.com/oasm-platform/open-asm/pull/641/files#diff-62c5b664f33e68aacc55adca067c52d121354153c594982c57ba1d5f502a907fR25-R31),[[2]](https://github.com/oasm-platform/open-asm/pull/641/files#diff-f76f201b2216d7b59d01187636ddedf504ed5746e4ea2be1feedd06ffbda4941R46-R49))