fix(worker): forward affected_url and description from findings - #643
Merged
Merged
Conversation
findingToVulnerability dropped matched_at, so Vulnerability.affected_url was always empty; map Finding.MatchedAt onto it. Also forward the new Finding.Description onto Vulnerability.description and regenerate the connector proto stubs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Finding.MatchedAt→Vulnerability.affected_urlinfindingToVulnerability. Previouslymatched_atwas dropped, so thevulnerabilities.affectedUrlcolumn was always empty.Finding.Description→Vulnerability.description.Finding.description = 15) and the source proto to stay in sync with the SDK.Why
Connector findings carried the affected URL (as
MatchedAt) and, after the SDK change, a description, but the worker discarded both before submitting to Core.Testing
task worker:test— passtask worker:lint/task worker:check— passjob_connector_test.goasserts thematched_at → affected_urlanddescriptionmappings.Companion SDK/connector changes: oasm-platform/oasm-connectors (branch
develop).