Skip to content

fix(#1046): support eo-parser 0.61.3 - #1051

Open
theaflit wants to merge 3 commits into
objectionary:masterfrom
theaflit:1046-fix-eo-parser-0613
Open

fix(#1046): support eo-parser 0.61.3#1051
theaflit wants to merge 3 commits into
objectionary:masterfrom
theaflit:1046-fix-eo-parser-0613

Conversation

@theaflit

Copy link
Copy Markdown

Closes #1046.

Changes

  • bump eo-parser from 0.61.1 to 0.61.3;
  • adapt wrong-test-order to the reordered XMIR structure;
  • determine source order using the line attributes instead of XML sibling order.

Verification

  • mvn "-Dtest=LtByXslTest#testsAllLintsByEo" -DskipITs test
  • 339 tests passed, 0 failures, 0 errors.

@github-actions github-actions Bot added the core Changes are made to core parts of the code base label Jul 16, 2026
@theaflit
theaflit force-pushed the 1046-fix-eo-parser-0613 branch 2 times, most recently from 62417fc to a90ceaa Compare July 16, 2026 16:59
Comment thread src/main/resources/org/eolang/lints/tests/wrong-test-order.xsl Outdated
@theaflit
theaflit force-pushed the 1046-fix-eo-parser-0613 branch from a90ceaa to e26dda9 Compare July 19, 2026 09:27
@theaflit
theaflit force-pushed the 1046-fix-eo-parser-0613 branch 2 times, most recently from 3984261 to ccad62b Compare July 19, 2026 10:34
@theaflit

theaflit commented Jul 19, 2026

Copy link
Copy Markdown
Author

@volodya-lombrozo xcop is still failing
The files are not modified in this PR, and the same failure is reproducible on the current master branch. The issue is tracked separately in #1053.
The changes in this PR are limited to the eo-parser 0.61.3 update and wrong-test-order fixtures.

@theaflit

Copy link
Copy Markdown
Author

@volodya-lombrozo All checks are green and the previous review comment has been addressed. Could you please review the latest version when you have a chance?

@yegor256

Copy link
Copy Markdown
Member

@volodya-lombrozo ping

[] +> runs-program
[] > boom
document: |
<object author="tests">

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theaflit Can we render elements in the input to make this test pass?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@volodya-lombrozo I tried rendering every element in the input by giving bar,
+runs-program, and boom a body.

However, with eo-parser 0.61.3, the resulting XMIR sibling order is
still changed from:

bar, +runs-program, boom

to:

bar, boom, +runs-program

Therefore, this approach still produces no defect. Unless you had a
different way of rendering the elements in mind, it seems that
document is needed here to preserve the sibling order tested by
this fixture.

@volodya-lombrozo volodya-lombrozo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theaflit There is a fresh version of EO parser, maybe it's better to use it now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Changes are made to core parts of the code base

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix failing tests after eo-parser bump to v0.61.3 (PR #995)

3 participants