fix(#1046): support eo-parser 0.61.3 - #1051
Conversation
62417fc to
a90ceaa
Compare
a90ceaa to
e26dda9
Compare
3984261 to
ccad62b
Compare
|
@volodya-lombrozo xcop is still failing |
|
@volodya-lombrozo All checks are green and the previous review comment has been addressed. Could you please review the latest version when you have a chance? |
|
@volodya-lombrozo ping |
| [] +> runs-program | ||
| [] > boom | ||
| document: | | ||
| <object author="tests"> |
There was a problem hiding this comment.
@theaflit Can we render elements in the input to make this test pass?
There was a problem hiding this comment.
@volodya-lombrozo I tried rendering every element in the input by giving bar,
+runs-program, and boom a body.
However, with eo-parser 0.61.3, the resulting XMIR sibling order is
still changed from:
bar, +runs-program, boom
to:
bar, boom, +runs-program
Therefore, this approach still produces no defect. Unless you had a
different way of rendering the elements in mind, it seems that
document is needed here to preserve the sibling order tested by
this fixture.
volodya-lombrozo
left a comment
There was a problem hiding this comment.
@theaflit There is a fresh version of EO parser, maybe it's better to use it now?
Closes #1046.
Changes
eo-parserfrom0.61.1to0.61.3;wrong-test-orderto the reordered XMIR structure;lineattributes instead of XML sibling order.Verification
mvn "-Dtest=LtByXslTest#testsAllLintsByEo" -DskipITs test