docs(service): state how many names the cases views section used to list - #1610
Merged
Merged
Conversation
The English paragraph under Standard list views stated six phantom names and dropped the denominator that both Chinese faces carry. The Chinese faces were right: this section's previous body listed seven names, six of them phantom, and the seventh — My Open Cases — is a real view that still stands in the table directly above the paragraph. Raise the English to the denominator rather than trim the Chinese, so all three faces state the same verified fact and no true claim is deleted. Only the English line changes; the two Chinese faces are already correct. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018xtjdpZFjgWh4Ad9Wcx68J
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
os-steve
marked this pull request as ready for review
September 5, 2026 23:42
This was referenced Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1542
Description
Under Standard list views on the cases page, one paragraph opened three different ways. The English stated six phantom names; both Chinese faces stated a list of seven of which six are phantom. This raises the English to the denominator the Chinese already carried.
The two Chinese faces were right, and they are deliberately left untouched.
What settled it
The card said that deciding this needs the page's own history rather than the current tree. That was correct, and the history answers it precisely — but only the half of the diff that is easy to skip.
Both sentences entered in a single change (
3087f211, landed as11f62429, 2026-08-06). That same change removed the list the two sentences point back at, and the removed side is the referent of "used to list" / 「原先列的」. Reading only the added side is what makes the Chinese look wrong.The pre-image at
834870cd:content/docs/service/cases.mdx, under## Standard list views, listed exactly seven names:src/views/case.view.ts:126(my_open_cases), and it is still a row in the views table just above this paragraphSix of those seven map 1:1 onto the six bullets the paragraph still carries, with none left over, and
834870cd:content/docs/service/cases.zh-Hans.mdxcarried the same seven. So 「本节原先列的七个名字里,有六个根本不是视图」 is exactly and literally correct. The English was terser rather than wrong: it stated the six and dropped the denominator.Parity is therefore reached by raising the English, not by trimming the Chinese. Deleting the "seven" would have removed a measured true fact to tidy an arithmetic — the mirror image of the other tempting non-fix, adding a seventh phantom bullet to reach seven, which would have invented a false claim on a page whose whole purpose is naming what does not exist.
The number is durable in a way a roster count is not: it describes what an earlier revision of this page listed, not what the app ships, so it cannot go stale as views are added or removed.
Type of Change
Related Issues
Fixes #1542
Changes Made
content/docs/service/cases.mdx:183— one line. It now names the seven-name denominator and My Open Cases as the one that was real and survived, then leads into the same six unchanged bullets..changeset/cases-phantom-count-states-the-denominator.md— added, carrying the measurement for the release-notes reader.content/docs/service/cases.zh-Hans.mdxand.zh-Hant.mdx— not edited. They were already correct.Testing
pnpm verifyexit 0, the whole chainpnpm verify(validate && typecheck && lint && lint:i18n-gate && hygiene && hygiene:tokens && build && test) ran green on16de80dc, each stage printing its own verdict:✓ Validation passed✓ i18n lint gate: 0 i18n/missing-* issues✓ source hygiene clean(including✓ no raw control bytes in first-party files)✓ source token ratchet clean✓ Build completeTest Files 160 passed (160)·Tests 3391 passed | 1 skipped834870cd, the 1:1 mapping onto the six bullets on16de80dc, andmy_open_casesinsrc/views/case.view.ts.One measurement caveat, stated rather than hidden: the clone is shallow. Its single boundary is
814dc372, which is neither11f62429nor its parent834870cd;834870cdresolves as a commit and834870cd:content/docs/service/cases.mdxresolves as a blob and reads with real content, so the pre-image is a direct positive read and needs no control leg.Additional Notes
Re-measured before pushing:
origin/mainis still8223d0aa, so this branch sits one commit ahead of the tip with no rebase needed.While measuring this paragraph I also measured the sibling page that the parallel card owns:
content/docs/service/sla-and-escalation.mdx:144, and both of its Chinese faces, saycrm_caseships seven views and then enumerate seven, omitting Unassigned — triage (src/views/case.view.ts:213,unassigned_triage). The views table on this page says eight and lists it, so that sibling page carries a stale roster count in all three faces. That page is out of scope here and was not touched — #1541 remains open and owns it.Generated by Claude Code
Generated by Claude Code