docs(inventory): drop the crm_product capabilities the catalog no longer has - #1619
Merged
Merged
Conversation
…ger has QUO-010 credited `crm_product` with `计费类型` (`billing_type`), `计量单位` (`unit_of_measure`) and `库存`; QUO-012 listed a 「低库存(≤10)标红视图」. None of them is on disk: `billing_type`, `unit_of_measure`, `quantity_on_hand` and `reorder_point` were removed, the `low_stock` view went with the fields it was built on, and all five survive only as tombstone comments in the two files those rows cite as their anchors. Deleted rather than softened — the capability is gone, not renamed, so there is no vaguer wording that would be true. The surviving clauses were re-derived from `src/objects/product.object.ts` (13 declared fields) and `src/views/product.view.ts` (two list views), not copied from any roster. Both numbered rows stay, so the 「产品:QUO-010~013」 range reference is intact. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018xtjdpZFjgWh4Ad9Wcx68J
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
os-steve
marked this pull request as ready for review
September 6, 2026 00:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1536
Two rows of
docs/feature-inventory.mdcreditedcrm_productwith capability that is not on disk. Both rows keep their number; the false clauses are deleted.What was false, measured on
origin/main@df549fef:119计费类型(billing_type)src/objects/product.object.ts:154:119计量单位(unit_of_measure):119库存(in 「定价与库存」)quantity_on_hand/reorder_pointare a tombstone comment,src/objects/product.object.ts:109:121low_stockis a tombstone comment,src/views/product.view.ts:11-15The sharpest form of it: each row names a source file as its anchor, and that same file states in prose that the capability the row claims is gone —
product.view.tssays the view "could not outlive" the fields it was built on.content/docs/revenue/products.zh-Hans.mdx:52already tells customers the opposite of what the internal inventory said, under the heading 「没有库存,也没有计费周期」.Deleted, not softened
The inventory capability was removed, not renamed, so there is no vaguer wording that would be true. A row that outlives its subject is the same defect one abstraction level up and harder to catch, because it would no longer name a specific missing field.
What I derived, and from which file
Re-derived from the two anchor files at
df549fef— deliberately not copied from the card's field list, since a hand-copied roster is the defect being fixed.src/objects/product.object.tsdeclares 13 fields:product_code,name,display_title,description,category,family,list_price,cost,sku,is_active,product_manager,image,datasheet. Every surviving QUO-010 clause maps onto one of them —PRD-{0000}isproduct_code.format, tenant-unique SKU issku.unique(the composite(organization_id, sku)its field comment explains),category/family, pricing islist_price/cost,imageplus PDFdatasheet, and 「全组织可读」 issharingModel: 'public_read'. 「定价与库存」 became 「定价(目录价/成本)」 so the remaining phrase names what it means rather than leaving a hole where 库存 was.src/views/product.view.tsdefines exactly two list views: theall_productsgrid grouped bycategory, and theproduct_cataloggallery covered byimage. That is what QUO-012 now says.Consequences checked rather than assumed
product.view.tsis still one of them, and there are still 14.:10keeps a numbered row and annotates it 「已移除」 when a feature point goes. Neither feature point went — 产品目录对象 and 产品视图 both still exist — so no annotation is due and 「产品:QUO-010~013」 at:271is untouched.:122is untouched. It is correct. The dispatch named:122as QUO-012's line; at this ref QUO-012 is:121.Not in scope here
#1198is not addressed here: nothing aboutcrm_product.tax_rateis touched. Measured at this ref, that field is already absent fromcrm_product(13 fields, not the 14 the card counted atf0a05613); the survivingtax_ratedeclarations belong tocrm_quote_line_item, and this file carries no tax-rate row.#1494is not addressed here. Whether an inventory should transcribe object capability at all remains open; this PR only makes the existing rows true.Gates
pnpm verifygreen in the worktree at230ba9e0— all eight stages ran (validate·typecheck·lint·lint:i18n-gate·hygiene·hygiene:tokens·build·test, 160 test files / 3394 tests passed).src/objects/product.object.tsandsrc/views/product.view.tsatdf549fef.Generated by Claude Code