You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[finding] the shipped enableOnInstall doc block says ManifestSchema and InstalledPackageSchema are "both declared here" — ManifestSchema is declared in kernel/manifest.zod.ts, and a pending changeset already copied the error #19748
立卡门 ① — a defect in a shipped, published-bound artifact.
finding — filed by the domain:spec execution seat 1 (session session_013RDBh5DqXd2xnLwvHLgLFr, seat post #6017). The platform dates this card. ⛔ Ungraded and unrouted: domain:*, type and priority are triage's. ⛔ Not claimed.
What is false
packages/spec/src/kernel/package-registry.zod.ts, in the doc block above the enableOnInstall key, under the heading 「⛔ Why the reference is documentary and not …Schema.shape.…」:
PackageInstallRequestSchema sits ABOVE this module in the import graph —
it is built from ManifestSchema and InstalledPackageSchema, both
declared here — so a reference from here up to it is an import cycle.
「both declared here」 is false. Only one of the two is declared in that file.
reading
origin/main @ c120dbdfb8
seeding tree 596090efbe
InstalledPackageSchema declared in kernel/package-registry.zod.ts
yes
yes
ManifestSchema declared in kernel/manifest.zod.ts
yes
yes
ManifestSchema in kernel/package-registry.zod.ts
import { ManifestSchema } from './manifest.zod'; — an import, not a declaration
same
⇒ false at today's tree and at the tree the block was written on. ⛔ Not stale, ⛔ not overtaken — wrong from the start.
Dark control: the same instrument for a near-miss declaration spelling returns 0, so the readings above are readings rather than an instrument that matches anything.
⚠️ The block's CONCLUSION is correct and ⛔ must not be "fixed" away
The import cycle is real through InstalledPackageSchema alone, and the block's ⛔ directive — 「Do not "fix" this into PackageInstallRequestSchema.shape.enableOnInstall」 — stands on its own. What is wrong is one clause of the stated reason, not the prohibition it supports.
⛔ Whoever takes this must not read "the reason is partly wrong" as "the rule is wrong". The likely one-clause repair is to attribute each schema to the file that declares it and keep the cycle argument resting on InstalledPackageSchema, ⛔ not to relax the directive.
Why it is worth a card rather than a note
It ships.packages/spec's files[] carries src/**/*.zod.ts, so this doc block is published bytes an author — or an AI — reads on a governed schema key.
⭐ It has already propagated once. The pending changeset .changeset/18605-enable-on-install-one-authority.md reproduces the same sentence almost verbatim on its line 19, and changeset version publishes that text into packages/spec/CHANGELOG.md. The copy was found by the at-tier contract review of PR docs(changeset): correct four statements in the pending enableOnInstall one-authority note #19747 (record 5783979248), which is how this card exists. ⇒ this is a source of error with a demonstrated copy path, ⛔ not an isolated typo.
It sits on a key whose contract has been re-ruled twice this week, so it is exactly the text a reader goes to when they want to know what is authoritative.
⚠️packages/spec/src/** is the 强制条款② path limb, so a PR here owes a contract review at CONTRACT_REVIEW_TIER whatever its declaration line says.
⛔ Not a licence to rewrite the block. The narrowest true repair is the target; this is a wrong attribution, not an invitation to restructure a doc block that is otherwise carrying its weight.
⛔ No census claimed. Whether other doc blocks in packages/spec/src/** attribute a schema to the wrong file is not measured here. Whoever takes this may find it worth one grep; this card asserts nothing about it.
Dedupe — queries run by this filer, with what was read
⛔ /search/issues not used: this container's proxy refuses it with a body carrying no total_count, so a naive parse prints a clean-looking zero. Repo-scoped semantic search was used instead, and it ranks by relevance rather than matching exactly, so a total_count from it is ⛔ not a count of matching cards.
query
read
verdict
package-registry.zod.ts doc block claims ManifestSchema and InstalledPackageSchema are both declared there, import cycle
both results — #19101 (open, OS_EAGER_SCHEMAS asymmetry between gen:openapi and gen:schema) and #19273 (closed completed, the .default(true) → .optional() work)
⛔ none: a bare toJSONSchema projection, four version grammars, and an ADR type: "ui-plugin" respectively
⚠️ Stated honestly: the top-ranked results of three queries were read, ⛔ not every card the ranker returned. No open or closed card found names this doc block, this sentence, or a wrong-file schema attribution.
Dedupe words:both declared here, ManifestSchema declared in manifest.zod, package-registry doc block import cycle, enableOnInstall documentary reference, wrong file attribution in a shipped doc block
立卡门 ① — a defect in a shipped, published-bound artifact.
finding— filed by thedomain:specexecution seat 1 (sessionsession_013RDBh5DqXd2xnLwvHLgLFr, seat post #6017). The platform dates this card. ⛔ Ungraded and unrouted:domain:*,typeandpriorityare triage's. ⛔ Not claimed.What is false
packages/spec/src/kernel/package-registry.zod.ts, in the doc block above theenableOnInstallkey, under the heading 「⛔ Why the reference is documentary and not…Schema.shape.…」:「both declared here」 is false. Only one of the two is declared in that file.
origin/main@c120dbdfb8596090efbeInstalledPackageSchemadeclared inkernel/package-registry.zod.tsManifestSchemadeclared inkernel/manifest.zod.tsManifestSchemainkernel/package-registry.zod.tsimport { ManifestSchema } from './manifest.zod';— an import, not a declaration⇒ false at today's tree and at the tree the block was written on. ⛔ Not stale, ⛔ not overtaken — wrong from the start.
Dark control: the same instrument for a near-miss declaration spelling returns 0, so the readings above are readings rather than an instrument that matches anything.
The import cycle is real through
InstalledPackageSchemaalone, and the block's ⛔ directive — 「Do not "fix" this intoPackageInstallRequestSchema.shape.enableOnInstall」 — stands on its own. What is wrong is one clause of the stated reason, not the prohibition it supports.⛔ Whoever takes this must not read "the reason is partly wrong" as "the rule is wrong". The likely one-clause repair is to attribute each schema to the file that declares it and keep the cycle argument resting on
InstalledPackageSchema, ⛔ not to relax the directive.Why it is worth a card rather than a note
packages/spec'sfiles[]carriessrc/**/*.zod.ts, so this doc block is published bytes an author — or an AI — reads on a governed schema key..changeset/18605-enable-on-install-one-authority.mdreproduces the same sentence almost verbatim on its line 19, andchangeset versionpublishes that text intopackages/spec/CHANGELOG.md. The copy was found by the at-tier contract review of PR docs(changeset): correct four statements in the pending enableOnInstall one-authority note #19747 (record5783979248), which is how this card exists. ⇒ this is a source of error with a demonstrated copy path, ⛔ not an isolated typo.Scope, and what this card is ⛔ NOT
5783988676). Fixing one without the other leaves the two disagreeing.packages/spec/src/**is the 强制条款② path limb, so a PR here owes a contract review atCONTRACT_REVIEW_TIERwhatever its declaration line says.packages/spec/src/**attribute a schema to the wrong file is not measured here. Whoever takes this may find it worth one grep; this card asserts nothing about it.Dedupe — queries run by this filer, with what was read
⛔
/search/issuesnot used: this container's proxy refuses it with a body carrying nototal_count, so a naive parse prints a clean-looking zero. Repo-scoped semantic search was used instead, and it ranks by relevance rather than matching exactly, so atotal_countfrom it is ⛔ not a count of matching cards.OS_EAGER_SCHEMASasymmetry betweengen:openapiandgen:schema) and #19273 (closed completed, the.default(true)→.optional()work)toJSONSchemaprojection, fourversiongrammars, and an ADRtype: "ui-plugin"respectivelyDedupe words:
both declared here,ManifestSchema declared in manifest.zod,package-registry doc block import cycle,enableOnInstall documentary reference,wrong file attribution in a shipped doc blockGenerated by Claude Code