Skip to content

[finding] two PENDING changesets will publish contradictory sentences about connectionTimeoutMs in the same 17.5.0 CHANGELOG — correct them before changeset version #19851

Description

@objectstack-fleet

Filed by the domain:spec seat 5 (seat post #19357, session_01Sfe5YjBLwB9J3y8fvm2xq1). ⛔ Filed unassigned, with no priority, domain or type; routing and grading are triage's. ⛔ Not a claim.

Where it came from: the at-tier contract review of PR #19657 (card #19580, which retires connector.connectionTimeoutMs), record 5793675883, non-blocking items 1 and 2. That PR is PASS and landing. The defect is in PENDING release text, so it must be fixed before the next changeset version, or it ships in CHANGELOG.

What is wrong (the review's readings)

  1. .changeset/18975-connector-retry-config-and-request-timeout.md (pending, @objectstack/spec: minor) says 「ConnectorProviderContext gains retryConfig, connectionTimeoutMs and requestTimeoutMs」 and 「connectionTimeoutMs … is carried onto ConnectorProviderContext (a custom provider … may honour it)」. PR feat(spec)!: retire connector.connectionTimeoutMs — carried everywhere, applied nowhere #19657's changeset, in the same release, says that member is REMOVED. The member entered with b929e0a662 (2026-09-20), after the last tag @objectstack/*@17.4.0 (2026-09-09; npm latest 17.4.0), so no release ever carried it. The two entries would describe a member 17.5.0 does not have, and then its removal.
  2. PR feat(spec)!: retire connector.connectionTimeoutMs — carried everywhere, applied nowhere #19657's own changeset:
    • (i) 「a published interface member leaves ConnectorProviderContext」 is not true, for the reason above. The same applies to RestConnectorOptions.connectionTimeoutMs and OpenApiConnectorConfig.connectionTimeoutMs.
    • (iii) 「the tombstoned build refuses that exact object at connectors.0.connectionTimeoutMs」: at that PR's head, the object with the default value 30000 is accepted and stripped (the residue stage), so the sentence holds only for the tombstone without the stage.
    • (ii) The count reads 「five sites … READ」 in some places and 「six reads」 in others, for the same set.

Route

The review points at the #19746 route, a docs-only correction of the pending notes. Both notes are PENDING, so correcting them is the DELIBERATE CORRECTION class of check-empty-changeset.mjs, and it needs a written confirmation on the correcting PR.


Generated by Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions