Skip to content

Why three engine-lane landings needed the maintainer this round (a pending release-note correction, a first-time queue-flake signature, a subagent's denied label write): can each become seat-decidable? #19940

Description

@objectstack-fleet

Ruled: 5814546887 · letter 1A · 2A · 3A · 2026-09-24T12:59Z

Filing gate: ③ a task the maintainer directed. The maintainer (huangyiirene), in the domain:engine#1 seat's session session_01TEhopqrWQYBycZzyJHpAZr (chat), 2026-09-24, verbatim: 「同时立一张skills卡,这些问题为什么需要我确认。」 The maintainer names the skills lane. ⛔ Routing labels are triage's, so this card is filed bare.

Filed by the domain:engine execution seat 1. ⛔ Not a claim.

The ask

Round 21 of the engine lane held three otherwise-ready PRs for a maintainer answer. In each case the maintainer's answer was a bare yes and added no information the seat did not already have on the PR. For each, answer:

  1. Which rule required the human?
  2. Is the human gate buying something there, or could a mechanical rule let the seat decide, with the evidence already on the PR as the record?
  3. If the gate should stay, how does the question reach the maintainer other than through one seat's chat?

Any rule change comes back as the skills seat's recommendation. New gates and gate loosening stay the maintainer's call.

Case 1 — PR #19928 (#19927): correcting a pending release note

  • What happened. PR fix(objectql): settle a chain of readonlyWhen locks on the drop set the stored row agrees with (#19927) #19928 made two passages of the unreleased .changeset/19911-readonlywhen-interdependent-locks.md false, so the dev corrected them in place, on the seat's instruction (option A). AGENTS.md's packages/*/CHANGELOG.md row keeps a correction in the entry it corrects, never in a later erratum. An isolated contract review then verified every rewritten sentence against measurement on the same head (record 5804807706 on A three-lock readonlyWhen cascade drops a write whose own lock is FALSE on the stored row: a legitimate edit is silently ignored #19927).
  • The rule that stopped it. scripts/check-empty-changeset.mjs, the DELIBERATE CORRECTION class (FOREIGN_CORRECTION_REMEDY, and the text around line 605): "Correcting a pending release note is a decision about a release rather than a refactor -- say so on the PR, naming the note and what changed under it, and get it confirmed ... this gate stays red either way, and staying red is what puts the decision in front of a person".
  • The seat's reading. landing-operations.md has a three-condition path for a check that is red by design. The gate's own text asks for a person. The seat took the stricter reading and held the landing (request 5804825048).
  • The maintainer's answer: 「确认 fix(objectql): settle a chain of readonlyWhen locks on the drop set the stored row agrees with (#19927) #19928」 (recorded with provenance, 5805828213).
  • Question. Can a contract-review PASS record on the same head, one that names the corrected note and judges each rewritten sentence, stand as the confirmation? Or is a release-note correction a release decision that must stay human? Either way, should the seat-side rule say which reading governs?

Case 2 — PR #19904 (#19868): a first-time merge-queue flake signature

Case 3 — PR #19857 (#19586): a subagent's denied skip-changeset write

Filing-gate answers

Dedupe words: landing needs maintainer confirmation · DELIBERATE CORRECTION pending release note confirm · new queue flake signature first ejection re-queue · subagent denied label write skip-changeset


Generated by Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions