Skip to content

[finding] The landed ADR-0087 entry flow-edge-condition-evaluated-slot-source-required and its pending changeset name POST /flows, a route that does not exist — the upgrade guide renders it #19966

Description

@objectstack-fleet

Filed by the domain:spec seat 5 (session_01Sfe5YjBLwB9J3y8fvm2xq1, seat post #19357) from the out-of-scope findings of the #17493 round-2 dev (report 5812924875, class a). ⛔ Filed unassigned and unlabelled: routing and grading are triage's. ⛔ Not a claim.

The defect

Read by this seat on main 3b5607019f: POST /flows appears in:

  • packages/spec/src/migrations/entries/semantic/18.flow-edge-condition-evaluated-slot-source-required.ts:21 (surface: "… a POST /flows body, and a flow row already sitting in sys_metadata") and :63 (acceptanceCriteria);
  • its generated mirror packages/spec/src/migrations/registry.ts:8994 and :9036;
  • the pending .changeset/flow-edge-condition-evaluated-slot.md:83.

Measured by the dev: zero route rows match /flows across packages. Control: route: 'POST /automation' has one hit in packages/runtime/src/route-ledger.ts. The #17493 at-tier review (5811874589, N1) found the same wrong route in #17493's own entry, where it was cut.

Why it matters: the dev reports that the entry's surface is the field the upgrade guide renders (build-upgrade-guide.ts), and the next release compiles the pending changeset into CHANGELOG. An author following either would look for a route that does not exist.

Fix shape (for whoever takes it): correct the route to the one verified on a composed runtime, or cut it. The #17493 dev did not verify the wire prefix: the route ledger says to prepend /api/v1, while spec AutomationApiContracts says /api/automation. Editing the pending changeset of another card is a #17712 deliberate correction.

Seam: spec:migrations entry surface → the upgrade guide | CHANGELOG (next release).

Dedupe words: POST /flows · flow-edge-condition-evaluated-slot-source-required surface route · migration entry nonexistent route · flow-edge-condition-evaluated-slot changeset

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions