Skip to content

docs(pm): drop the stale shadowing claim from dispatch-gates' selfTest comment #15345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-steve merged 1 commit into from
Sep 4, 2026
Merged

docs(pm): drop the stale shadowing claim from dispatch-gates' selfTest comment #15345

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions scripts/pm/dispatch-gates.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17685,11 +17685,10 @@ function selfTest() {
}
return { sites, perRoot };
};
// `relative` from `node:path` is SHADOWED inside this function — a fixture
// string a few thousand lines up binds that name — so the repo-relative
// spelling comes from ROOT, the prefix every sibling case here already joins
// against. A prefix that stops holding yields an empty root, which the walk
// above reports rather than turning into a pass.
// The repo-relative spelling here comes from ROOT, the prefix every sibling
// case in this block already joins against — the consistent spelling, not a
// workaround. A prefix that stops holding yields an empty root, which the
// walk above reports rather than turning into a pass.
const tierOwnAbs = fileURLToPath(import.meta.url);
const tierOwnRel = tierOwnAbs.startsWith(ROOT) ? tierOwnAbs.slice(ROOT.length) : '';
// The definition line is FOUND, not remembered: the one line carrying both
Expand Down
Loading