docs(agents): Protocol Domains table names marketplace/ where cloud/ used to be - #17838
Merged
os-zhuang merged 1 commit intoSep 12, 2026
Merged
Conversation
…used to be The Protocol Domains table in AGENTS.md still listed a `Cloud` / `cloud/` row after the cloud control-plane contracts left the open-source spec and the package & marketplace format moved to `packages/spec/src/marketplace/`, published as `@objectstack/spec/marketplace`. The row named a directory the tree no longer has and omitted the one that replaced it. Replace it with a `Marketplace` / `marketplace/` row at the same alphabetical position (after `Kernel`), described from the directory's actual modules. One line in, one line out — 1075 lines before and after. Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MCLBsUgfykL74aU716rzVK
Contributor
Author
维护者速读改了什么 — 为什么改 — #16325(你「同意」的 option B「cut by owner」)把云控制面协议移出开源 spec、包与市场格式搬到 风险与代价(含回滚) — 纯文档一行,不碰任何包、不发布任何东西,14 个派生门禁全绿;回滚即 revert。 席位意见 — 接受(ACCEPT 5645296196,契约档复核)。附带更正一处本席误读:派发令说 AGENTS.md 有一条「Prime Directive #8 行宽规则」,实际 PD#8 是北极星对齐,文件没有行宽规则;约束表格行的是棘轮脚本的 768 字节表行 pin,本行远在其下。 你要做的 — 受管面,只能人工合并:看一眼「Package, Version, Listing, Install, Template」这五个词是否合意(比卡片原提案短,理由是与邻行同写法),合并 PR #17838 即可;想保留长版就说一句。 Generated by Claude Code |
This was referenced Sep 12, 2026
os-zhuang
approved these changes
Sep 12, 2026
os-zhuang
marked this pull request as ready for review
September 12, 2026 15:22
os-zhuang
enabled auto-merge
September 12, 2026 15:22
os-zhuang
deleted the
claude/issue-17370-agents-protocol-domains-marketplace-row
branch
September 12, 2026 15:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Protocol Domains table in
AGENTS.mdstill listed aCloud/cloud/row after the cloud control-plane contracts left the open-source spec and the package & marketplace format moved topackages/spec/src/marketplace/, published as@objectstack/spec/marketplace. The row sent a reader to a directory the tree no longer has, and omitted the one that replaced it. This replaces that one row with aMarketplace/marketplace/row at the same alphabetical position (afterKernel), described from the directory's actual modules rather than from the card's proposal. One line in, one line out — 1075 lines before and after. Docs-only,skip-changeset.Fixes #17370
Acceptance notes
The row
Premise findings, re-taken on
origin/main51b024a16(the PM took them ond79f2499;mainadvanced by twodocs(pm)commits, #17828 and #17823, neither touchingAGENTS.md)Holds.
AGENTS.md:657read|Cloud|cloud/| Multi-tenant, deployment, environment |directly after theKernelrow at:656; the file is 1075 lines.Holds.
git ls-tree -d origin/main packages/spec/src/marketplaceanswers040000 tree 3f19482…;packages/spec/src/cloudanswers nothing.packages/spec/package.jsonexports./marketplace, and has no./cloud.Holds.
git grep -ln "Multi-tenant, deployment, environment" origin/mainhits onlyAGENTS.md;git grep -ln "Protocol Domains" origin/main -- scripts .github packages/spec/scriptshits nothing. No gate reads this table.Holds, re-measured. All 22 open PRs' file lists scanned at this commit, fully paginated (PR chore: version packages #17076 is the standing Version Packages PR at 383 changed files — four pages read). None touches
AGENTS.md.FALSIFIED — the dispatch's line-width premise. The dispatch named "AGENTS.md's own line-width rule, Prime Directive Convert to monorepo with scoped packages #8" wrapping at ~84–90 bytes. There is no such rule. Prime Directive Convert to monorepo with scoped packages #8 is North Star alignment;
AGENTS.mdcarries no line-width rule at all. The real 120-byte budget isMAX_LINE_BYTESinscripts/pm/check-skill-line-ratchet.mjs, and it exempts a markdown table row by shape (EXEMPTION_CLASSES.table: "a wrapped|row is a different table"). What actually binds a table row is that script's second ratchet,MAX_TABLE_ROW_BYTES, pinned forAGENTS.mdat 768 bytes, shrink-only, headroom 0. The new row is far under it, and the gate's own verdict lines confirm both pins are untouched:The dispatch's operative instruction — stay within the table's own widest row — was honoured anyway; see the width note below.
Work item B — other
cloud/references in AGENTS.mdgit grep -n "cloud/" origin/main -- AGENTS.mdreturns exactly one hit: line 657, the row being replaced. Nothing else in the file to report, and nothing else was touched.The description, verified against the directory
git ls-tree -r --name-only origin/main packages/spec/src/marketplacelists ten files — five modules and five test files:The card proposed 「Package identity & versions, marketplace listing / publish / install format, template manifests」. That description is accurate — it does not overstate — but it is 132 bytes as a row, against a table whose widest row is 84, and its
&//punctuation is out of register with its neighbours, which are bare comma-separated noun lists of the domain's principal schemas (Data→ "Object, Field, FieldType, Query, Filter, Sort";Security→ "Permission, Role, Policy"). So it was shortened into that register, one noun per real schema family, each traceable to a module's top-level exports:Packagepackage.zod.tsPackageSchema,PackageTranslationsSchema,CreatePackageRequestSchemaVersionpackage-version.zod.tsPackageVersionSchema,PackageManifestSchema,PublishPackageVersionRequestSchemaListingmarketplace.zod.tsMarketplaceListingSchema,PackageSubmissionSchema,MarketplaceSearchRequestSchemaInstallmarketplace.zod.tsMarketplaceInstallRequestSchema,MarketplaceInstallResponseSchemaTemplatetemplate-manifest.zod.tsTemplateManifestSchema— the on-diskobjectstack.manifest.jsondescriptorpackage-l10n.tsis the listing-localisation resolver overPackageTranslationsand folds underPackage; the neighbouring rows do not enumerate helper resolvers either (Shared→ "Error maps, normalization utilities").Byte width of the new row versus the table's widest
MarketplacerowUI(:649)Cloudrow (replaced)MAX_TABLE_ROW_BYTESpin for AGENTS.md (the gate)The new row is 3 bytes under the table's own widest and 687 under the enforced pin.
Gates
Derived in this worktree with
node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack(no paths — the tool takes its own change set from the merge base). 14 families derived, 14 run, all exit 0:Reconciled:
node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --ran RANFILE(exit codes recorded per family) →All gate readings above were taken at
f68b09653, the final commit on this branch.No build or test family is owed: the diff touches no package, so the closure build is empty and no package's
pnpm test/pnpm typecheckis in scope. Control-byte self-scan beyondcheck:nul-bytes:grep -naP '[\x00-\x08\x0b\x0c\x0e-\x1f\x7f]' AGENTS.mdexits 1 with zero output.Changeset
skip-changeset. Measured, not assumed: of the 76 tracked package manifests, zero published package lists anything matchingAGENTSin itsfiles[], against a positive control of 70 published packages that do listREADME.AGENTS.mdis a repo-root instruction file and ships in no tarball, so this PR publishes nothing.Governed surface
AGENTS.mdis a governed surface (Prime Directive #14). This PR stays a draft; it is never flipped ready, never queued, and auto-merge is never armed by this seat. The PM places the four-piece and the maintainer merges.维护者速读(草稿)
改了什么 —
AGENTS.md的 Protocol Domains 表里那一行Cloud/cloud/换成了Marketplace/marketplace/,位置不变(仍在Kernel之后,按字母序),描述按目录里实际有的五个模块重写。整个 PR 就这一行,进一行出一行,文件 1075 行前后不变。为什么改 — #16325 把云控制面的协议移出开源 spec(option B「cut by owner」,维护者「同意」),包与市场格式搬到了
packages/spec/src/marketplace/。那一行从此指着一个不存在的目录,并且漏掉了顶替它的那个。没有任何门禁读这张表,所以它只会一直烂着,不会变红——这正是要人来修的原因。风险与代价(含回滚) — 风险接近于零:纯文档一行,不触碰任何包,不发布任何东西,14 个派生门禁全绿。回滚就是把这一行改回去,一次 revert 即可,没有任何下游依赖。唯一需要留意的是这是受管面,必须由维护者手工合并。
席位意见 — (留空,待席位定稿)
你要做的 — 确认
Marketplace行的描述用词是否合你的意:目前是Package, Version, Listing, Install, Template,比卡片原提案短,理由是要和表里其他行同一种写法(裸名词列表)、同一个宽度量级(81 字节,表内最宽 84)。如果你更想保留卡片原来那句更长的描述,告诉我,我改。确认后由你手工合并。Generated by Claude Code