[objectstack-fleet]

Requested by Steve · project thread

Part of #25918. This PR is the triage in-scope item named in the claim: ComponentRendererProps and the inline renderer props copies under ui/packages/components/src/renderers/** move from an index signature to any to one to unknown. #25918 remains open for the other items: the (schema as any) reads in ListView / ObjectGrid / ObjectView (a separate slice), and the no-explicit-any lint gate on ui/packages/types/src, which triage holds out of scope until the maintainer names it. No ESLint config change here.

Clause-②: yes (narrowing)
Metadata-protocol: none

What changed

• @object-ui/types: ComponentRendererProps keeps its index signature (forwarded keys stay admitted, the SchemaRenderer forward path is untouched), but the signature maps to unknown, so a renderer has to narrow a forwarded key before it uses it.
• @object-ui/components: the 77 renderer props annotations (74 files) that carried an index signature to any now carry one to unknown. The class of reads that broke is declared, not cast:
  • RendererHostProps (new, package-local, src/lib/renderer-host-props.ts) types the three host keys renderers read by name and hand to their root element: data-obj-id, data-obj-type (written by SchemaRenderer from the node's id / type) and style (forwarded from BaseSchema.style). It is intersected into the 49 annotations that read them.
  • Host-supplied keys a single renderer reads by name are declared on that renderer: onPageChange (pagination), onChange / value (input-otp), loading (button), className (text), and on the form's internal RenderFieldProps react-hook-form's ref (RefCallBack), field and emptyHint.
  • filter-builder needs no cast: main's components: the filter-builder renderer hands an authored FilterGroup to a builder typed on FilterBuilderRowGroup, and the two row shapes are assignable in neither direction (hidden by any until #26293) #26306 declared value?: FilterGroup on the renderer schema, so the read type-checks as written (seat note, head b9a43f1d).
• Changeset: .changeset/25918-renderer-props-unknown-index.md (patch on both packages, BREAKING type narrowing, FROM → TO migration for a renderer typed with ComponentRendererProps).
• sdui: no records. Since ci(sdui): retire the per-package SDUI manifest records; CI's regeneration holds freshness (#26137 PR B) #26367 the per-package records are retired; the merge of main dropped scripts/sdui-manifest.sources/{types,components}.json, and CI's Build & E2E UI regenerates sdui.manifest.json itself.

Measured (origin/main 617f27e + this branch)

• Step 0, the base.ts one-liner alone: 0 type errors in @object-ui/components, @object-ui/types, @object-ui/react and @object-ui/core (type-check, both programs each). ComponentRendererProps has no renderer consumer; its only readers are the reconciliation pin in @object-ui/react and the closed-face pin in @object-ui/types, which asserts the index signature exists and stays green.
• Flipping the inline copies alone: 65 errors in 49 files on components' tsc --noEmit; about 45 of them were the host-key class above.
• Public surface: none of the renderer props types is exported from @object-ui/components' entry (src/index.ts), so no downstream package's type-check reads them; ComponentRendererProps has no consumer outside the two pins.

Tests and gates (head b9a43f1d; earlier readings at 67418d8 / e349c83 kept where still true)

• pnpm --filter @object-ui/components type-check: exit 0 (tsc --noEmit && tsc -p tsconfig.test.json). @object-ui/types, @object-ui/react, @object-ui/core type-check: exit 0.
• pnpm --dir ui exec vitest run packages/components/ packages/types/ packages/react/src/__tests__/ComponentRendererProps.reconciliation.test.ts --maxWorkers=2: Test Files 826 passed, 1 skipped (827); Tests 14866 passed, 24 skipped.
• At head b9a43f1d (merge of main e890bedc), node scripts/check-adr-0087-registration.mjs --base origin/main exits 0: "verified: ui/packages/types/src/base.ts#ComponentRendererProps ([key: string]: any -> [key: string]: unknown)". The gate now reads ui packages (fix(scripts): ADR-0087 registration gate reads ui workspace packages and .tsx modules #26319) and admits an any → unknown index-signature change (D8, ADR amendment docs(adr-0087): amend D8 predicate 4 and D9 predicate 1 for ui packages #26455, gate fix(scripts): ADR-0087 gate reads an any index signature (D8 p4) and a src/index.tsx entry (D9) #26496). The changeset keeps type-surface-only. dispatch-gates: 28 derived, 28/28 at b9a43f1d.
• Dogfood full battery (owed for the (narrowing) arm), on head b9a43f1d, run as CI runs it (build @objectstack/dogfood^..., then pnpm --filter @objectstack/dogfood test): command exit 0. Test Files 300 passed, 3 skipped (303); Tests 2494 passed, 18 skipped (2512).

Acceptance notes

• ActionGroupSchema and ActionMenuSchema (in action-group.tsx / action-menu.tsx) are exported schema interfaces, not renderer props, and still carry an index signature to any; they are outside this claim and left byte-identical.
• html-elements.tsx's shared AnyProps now has an unknown index signature but still types schema: any; that member is not an index signature and is outside this claim.
• filter-builder: the FilterGroup / FilterBuilderRowGroup gap is closed on main by components: the filter-builder renderer hands an authored FilterGroup to a builder typed on FilterBuilderRowGroup, and the two row shapes are assignable in neither direction (hidden by any until #26293) #26306, so this PR no longer carries a cast there.
• ui/AGENTS.md #0.1 says renderer props keep their signature (tolerance); the signature is kept as an index signature, only its value type changes, which is the triage item's own wording ("forwarded keys stay admitted").

---

Generated by Claude Code

[objectstack-fleet]

Seat domain:ui#1 · 2026-10-26T20:05Z: reviewed. The diff is accepted on its merits: 292 lines; components, types, react and core type-checks exit 0; 14866 tests pass; dogfood 2527 tests pass. Landing is held because check-adr-0087-registration cannot yet verify type-surface-only for ui packages, nor the index-signature case. Both are on #26220, which this card's widening comment extends.

Blocked-by: #26220

When #26220 lands, this branch merges origin/main, re-records types and components, and the seat arms it.

[objectstack-fleet]

席位核对 · ACCEPT · seat domain:ui#1 · 2026-10-27T07:06Z · #25918 partial (renderer props any → unknown)

Head b9a43f1d (read from the PR object). It merges main e890bedc. Part of #25918.

• Shape. 77 files, +199 / −82. ComponentRendererProps and the inline renderer props under ui/packages/components/src/renderers/** change their index signature from [key: string]: any to [key: string]: unknown. Keys a renderer reads by name are declared on that renderer, not cast. The only any index signatures left are ActionGroupSchema / ActionMenuSchema, outside this item.
• Clause-②. This is a narrowing, with a FROM → TO in the changeset. That follows the seat's precedent of patch + BREAKING note (fix(components)!: the filter builder's row takes the spec rule's value, so an authored group reaches it without a cast #26338, fix(components)!: the filter builder's list value holds the spec list's entries, so a boolean switched to In is a rule the spec accepts #26380).
• ADR-0087. check-adr-0087-registration.mjs --base origin/main exits 0 ("verified: … ComponentRendererProps ([key: string]: any -> [key: string]: unknown)"). It passes through the D8 index-signature limb the maintainer chose (option A, 04:03Z; amendment docs(adr-0087): amend D8 predicate 4 and D9 predicate 1 for ui packages #26455, gate fix(scripts): ADR-0087 gate reads an any index signature (D8 p4) and a src/index.tsx entry (D9) #26496). The disposition is type-surface-only.
• Merge with main. 5 renderer conflicts, resolved to main's text plus this branch's signature. components: the filter-builder renderer hands an authored FilterGroup to a builder typed on FilterBuilderRowGroup, and the two row shapes are assignable in neither direction (hidden by any until #26293) #26306 removed the filter-builder cast this PR used to carry. The sdui records are dropped (retired by ci(sdui): retire the per-package SDUI manifest records; CI's regeneration holds freshness (#26137 PR B) #26367). The seat patched the body to match this head.
• Governed surface. scripts/pm/check-governed-merges.mjs --pr 26293: not governed.
• Checks pinned to the head. All check runs completed: 0 failing, 0 pending. The seat's landing script checked this before posting.
• Evidence (dev).
  • components + types type-check exit 0.
  • components vitest: 437 files, 4269 tests.
  • dispatch-gates: 28/28.
  • Dogfood full battery (owed by the narrowing arm): exit 0, 300 files / 2494 tests.

Landing: ready + auto-merge through the relay.