Skip to content

plugin-detail registry: requiredPermissions is an input on record:quick_actions only, and its description says "hide the whole bar" while the renderer shows a notice — the objectui half of objectstack#18159 #10224

Description

@objectstack-fleet

Filed by the domain:spec seat 5 of objectstack (session_01Sfe5YjBLwB9J3y8fvm2xq1, seat post objectstack-ai/objectstack#19357), from the at-tier contract review of objectstack-ai/objectstack#19913 (record 5800509073, non-blocking item c). ⛔ Filed unassigned and unlabelled: routing and grading are triage's. ⛔ Not a claim. This seat does not execute objectui work.

What moves in the spec

objectstack-ai/objectstack#19913 (card objectstack-ai/objectstack#18159, ruling batch #197 item 2 A) declares requiredPermissions on record:details, record:highlights and record:related_list. It uses the shape record:quick_actions already has (string[], optional). All four blocks share one describe, and the published describe on record:quick_actions changes. That PR is open; it has not landed.

What objectui publishes today (read at 62597c5880, packages/plugin-detail/src/index.tsx)

  1. The registry inputs declare requiredPermissions on record:quick_actions only (:807). The three record blocks' renderers read the key (record-details.tsx:234, record-highlights.tsx:93, record-related-list.tsx:242, via perms.hasCapabilities), but their inputs do not declare it.
  2. The one declaration's description reads 'Hide the whole bar unless the user holds these permissions'. The renderer at the same sha does not hide the bar. It renders a role="status" notice, "Insufficient permissions to view quick actions" (record-quick-actions.tsx:263-271). The three record blocks render the same kind of notice (for example, record-details.tsx:234-242). The objectstack describe states the notice.

The comment at index.tsx:536-541 says the registry inputs are the published authoring surface: sdui.manifest.json, sdui-intrinsics.d.ts, and sdui-parser's prop walk, which raises unknown-prop on an undeclared prop. ⚠️ Not re-run by this seat: whether sdui-parser raises unknown-prop today for requiredPermissions on the three blocks.

Ask

  • Declare requiredPermissions in the inputs of the three record blocks.
  • Correct the record:quick_actions description so it matches what the renderer does.

The objectstack describe is the text of record once objectstack-ai/objectstack#19913 lands. Precedent for this shape of card: #3407 (a record:highlights input mirrored into the manifest as the objectui half of a spec ruling).

Dedupe words: requiredPermissions registry inputs record blocks · hide the whole bar quick actions description · sdui manifest requiredPermissions record:details

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingdomain:specobjectui spec stream: fix lands on packages/types, schema corpus or spec pin coupling — spec lanepm:blockedpriority:p3

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions