Skip to content

docs(plugin-gantt): stop instructing the retired navigation.view in the published README (objectui#9987) - #10090

Merged
os-tesla merged 1 commit into
mainfrom
claude/issue-9987-gantt-readme-navigation-view
Sep 20, 2026
Merged

os-tesla merged 1 commit into
mainfrom
claude/issue-9987-gantt-readme-navigation-view

Conversation

@os-tesla

Copy link
Copy Markdown
Collaborator

Fixes #9987

Clause-②: no — a published README and the test that runs its example. It moves no exported symbol and no key on a published payload.

What the paragraph did

packages/plugin-gantt/README.md is listed in that package's files[], so it ships inside the npm tarball. Its record-navigation paragraph instructed an author to write the member @objectstack/spec retired under ADR-0049 (objectstack-ai/objectstack#18619) — and then, in the same paragraph, explained the mechanism by which an undeclared key rejects the whole config. The first sentence caused what the second diagnosed, and a reader who stops at the instruction never reaches the contradiction.

Premise re-taken on today's origin/main before any edit

All three legs, each with its control lit in the same command:

  1. The two sentences are still there — at packages/plugin-gantt/README.md lines 54–62 on 0c2eb5eee (the card cited 1db82373f; the text, not the line number, is the anchor). Both quoted verbatim in the card matched byte for byte.
  2. README.md really is in files[]["dist", "README.md", "CHANGELOG.md", "LICENSE"]. ⭐ Control in the same reading: ROADMAP.md sits in the same directory, has the same extension, and is not in files[] — so the instrument distinguishes shipped from not-shipped rather than saying yes to every .md in the folder. demo/, docs/, scripts/, src/ and the two tsconfigs are likewise absent.
  3. The spec declares a tombstone, not a removal — objectstack main (cdedfb348) packages/spec/src/ui/view.zod.ts:1971 reads view: retiredKey(NAVIGATION_VIEW_RETIRED), and the comment above it says why: the key stays in the shape so tsc types it never and a value reaching a parse raises the prescription instead of a bare unrecognized-key report. That distinction is load-bearing for this repair, and is why the surviving sentence below is not re-pointed at view.

The repair

The instruction is gone. In its place is the route the retirement actually leaves standing, carried in from the carrier the card names — @object-ui/react's useNavigationOverlay docblock — in the README's own voice, without restating the retirement's reasoning:

Which detail layout opens is not authorable here either: assign a record page to the object and let isDefault pick the one that opens. Page assignment is what resolves a detail layout; this block only decides how that detail is surfaced (mode, size) — @object-ui/react's useNavigationOverlay docblock owns that account.

⚠️ Deleting the sentence was not the repair on its own. It answered a real authoring question, and a reader who loses the answer goes looking and finds the retired key elsewhere. The replacement answers the same question.

⚠️ The second sentence is kept, byte-identical. «an undeclared key rejects the whole config, so the mode beside it never takes effect either» is true and it is the only place this README tells an author why a typo costs them the whole block. Only its line wrapping moved — proved below. It now stands as the generic strictness warning it always was, and stops being a description of what the paragraph above it told the reader to do. ⛔ It is deliberately not re-pointed at view: after the retirement view is a declared tombstone raising a prescription, not an undeclared key, so aiming this sentence at it would describe the failure wrongly.

Neither neighbouring carrier is folded in. packages/react/src/hooks/useNavigationOverlay.ts line 31 spells the same shape and the card checked it CLEAN — it is the tombstone's own account of past behaviour, with the replacement stated four lines below it. packages/types/src/objectql.ts is objectui#9938's site. Neither is touched by this diff.

The test is the other half of the deliverable

packages/plugin-gantt/src/readme-navigation-example.test.ts existed, was green, and would have stayed green through this defect for a structural reason worth stating: it extracts the json fence, and the fence never carried the key. The instruction lived entirely in prose. So the file now measures the prose as well.

⚠️ Nothing schema-derived can say view is retired in this tree. The pinned @objectstack/spec@17.4.0 still DECLARES it — measured, not assumed: NavigationConfigSchema's shape reads ["mode","view","preventNavigation","openNewTab","size","width"] and safeParse({ mode: 'page', view: 'summary_view' }) succeeds. So declaredMembers() reports the key legal, and every schema-derived statement about it would be vacuous here. It is therefore named by hand — exactly as basePath already is in this same file — and the empty result carries its own control:

  • does not INSTRUCT the retired detail-view key, in prose or fence — no code span in the section equals view, and summary_view appears nowhere in it.
  • CONTROL: the same detector finds the key in the sentence that carried it — the same codeSpans() is run over the removed sentence, verbatim, and must return ['view']. If the detector ever stops firing there, the clean section above says nothing at all.
  • still answers the question the retired instruction answered — the section must still name record and isDefault. These are identifiers, not wording: the sentence may be rewritten freely as long as it still hands the reader the route.

Evidence

RED before / GREEN after, file state verified in the SAME command as each run:

BEFORE   README blob 7461cf5744e830a928ba58857ba6363ab92eb241 · vs HEAD: UNMODIFIED
         instruction grep -c 1 · summary_view 1 · isDefault 0
         Test Files 1 failed (1) · Tests 2 failed | 6 passed (8)
           × does not INSTRUCT the retired detail-view key, in prose or fence
               expected [ 'view' ] to deeply equal []
           × still answers the question the retired instruction answered
               expected [ 'record', 'isDefault' ] to deeply equal []
           ✓ CONTROL: the same detector finds the key in the sentence that carried it

AFTER    README blob 3695c7b1ba736c57ebb4f8c87b69022cd43a87d6 · vs HEAD: MODIFIED-by-this-repair
         instruction grep -c 0 · summary_view 0 · isDefault 1
         Test Files 1 passed (1) · Tests 8 passed (8)

The control test passed on both runs: the detector was lit before the repair and is still lit after, so the zero is a measurement and not a broken instrument.

The kept sentence is byte-identical, with its own control. Whitespace-normalised, the substring from `navigation` is the spec to owns the member list. compares EQUAL between HEAD:packages/plugin-gantt/README.md and the worktree — while the same instrument applied to the half that should have changed reports DIFFERENT. And the same fixed-string grep that finds the removed instruction (use the declared `view` member) once in the file at HEAD finds it zero times in the repaired file.

No ablation was run, and that is a statement rather than an omission. Nothing in this diff is a guard whose failure mode needs proving by mutation — the RED-before run already is the "can this fail" leg, taken against the real published text rather than an injected one, and it failed for exactly the two reasons named.

Gates — re-run as the LAST action before the push

Tree verified equal to the pushed commit 9ef577d38, git status --porcelain empty, at the time of the run. Exit codes captured before any pipe.

Gates that do select a package README (established by reading each script's own surface declaration, ⛔ not assumed):

gate exit
check-doc-fence-languages.mjs 0
check-doc-snippet-types.mjs 0 — 672/672 blocks judged
check-doc-component-types.mjs 0
check-doc-example-types.mjs 0
check-readme-exports.mjs 0 — 37 of 40 packages read, 544 self-imports judged, population NOT collapsed
check-doc-links.mjs 0 — its SCAN_ROOTS carries packages/*/README.md
check-doc-expression-carriage.mjs 0
check-doc-example-shared-reader.mjs 0

⚠️ check-readme-exports.mjs FAILS by design on an unbuilt tree (population COLLAPSED -- this run proves nothing). The green above is from a run after all 39 package dist/ trees were built; the collapsed run is not being reported as a pass.

check-doc-example-ids.mjs does not select package READMEs — its own header rules the population to content/docs/** on purpose — so it is not in the list above.

Everything else run on the same tree: check-changeset-presence 0, check-changeset-claims 0, check-pending-changeset-literals 0, check-changeset-fixed 0, check-changeset-no-major 0, check-control-bytes 0, check-new-cross-file-line-citations 0, check-test-path-roots 0, check-unreferenced-sources 0, pnpm --filter @object-ui/plugin-gantt lint 0 (0 errors, pre-existing warnings only), pnpm --filter @object-ui/plugin-gantt type-check 0, and the package suite from the repo root — pnpm exec vitest run packages/plugin-gantt/69 files, 541 tests, all passing.

Governed-surface guard, asked rather than assumed: check-governed-queue-guard.mjs --test over the three changed paths returns NOT GOVERNED, with AGENTS.md run through the same command as a lit control returning the governed verdict.

Changeset — decided by running the gate, not from memory

check-changeset-presence.mjs demanded one, and the file it named is the test under src/, not the README: that gate subtracts *.md from published source on purpose («published-but-not-code sits with the READMEs»), and its header answers a change confined to tests with the empty-frontmatter exemption in one line. So .changeset/9987-gantt-readme-navigation-view.md carries an EMPTY frontmatter and says so in prose, including the part that argues the other way — the README genuinely is in the tarball. No runtime behaviour, no export and no published-contract field moved, and every package here is in one fixed group, so the corrected README reaches npm with the next release either way. ⭐ A reviewer who wants this to carry a patch can flip it in one line; the reasoning is written down rather than assumed.

Acceptance notes


Generated by Claude Code

… the published README (objectui#9987)

The README's record-navigation paragraph told an author to write the
member that `@objectstack/spec` retired under ADR-0049
(objectstack-ai/objectstack#18619) — and then, in the same paragraph,
explained the mechanism by which an undeclared key rejects the whole
config. The first sentence caused what the second diagnosed. This file
is listed in `files[]`, so the instruction shipped in the npm tarball.

The instruction is replaced by the route the retirement actually leaves
standing, carried in from `@object-ui/react`'s `useNavigationOverlay`
docblock: assign a `record` page to the object and let `isDefault` pick
the one that opens. Deleting the sentence alone was not enough — it
answered a real authoring question, and a reader who loses the answer
goes looking and finds the retired key elsewhere.

The second sentence is kept byte-identical (modulo re-wrapping): it is
the only place this README tells an author why a typo costs them the
whole block. It just stops being a description of what the paragraph
above it told them to do.

`readme-navigation-example.test.ts` now measures the PROSE as well as
the fence. The fence tests could never have caught this — they extract
the ```json block, and the block never carried the key. The pinned
`@objectstack/spec@17.4.0` still declares `view`, so nothing
schema-derived can say it is retired in this tree; it is named by hand,
exactly as `basePath` already is, and the absence carries its own
control: the same detector is run over the sentence that used to carry
the instruction and must find it there.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018HrVaotisyhgmot9o2MLRq
@github-actions github-actions Bot added documentation Improvements or additions to documentation plugin tests labels Sep 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

changeset-claim-re-read

⚠️ 2 pending changeset(s) describe a file this change touches

Their bodies publish verbatim into the CHANGELOG at the next release, so this is a request to re-read them against your diff — addressed here because you are the one seat that can answer it without re-deriving anything.

⛔ Nothing here blocks, and nothing here is a verdict on your change. This gate exits 0, is not a required context, and judges name resolution, never meaning: it asked whether a pending body names a file you touched. "Is this sentence still true?" is the one question it will not answer, and the one you are being asked to answer.

.changeset/6050-gantt-navigation-basepath.md

  • names src/readme-navigation-example.test.tspackages/plugin-gantt/src/readme-navigation-example.test.ts — edited by this change

    No gate in this repo could have caught the original defect, and that is why the fix ships with a measurement rather than a re-reading: check-doc-snippet-types compiles ts/tsx fences and check-doc-component-types reads type literals, and both are structurally blind to a metadata key in a README — the former's own header records schema-key validity as "a different question … left unruled on purpose". src/readme-navigation-example.test.ts closes that hole for this example by EXTRACTING the fence from the README on every run and parsing it against NavigationConfigSchema, with a control asserting the same parse still rejects an undeclared key by name, so the green cannot come from a schema that accepts everything.

.changeset/6470-gantt-dependency-field-deprecated.md

  • names packages/plugin-gantt/README.mdpackages/plugin-gantt/README.md — edited by this change

    packages/plugin-gantt/README.md's ObjectGanttSchema example authored the singular; it was the only in-repo site that did, and it now authors the plural with the alias named as legacy. No runtime code, fixture, example app or catalog schema authored it.

Read the paragraph, not the line: both false halves of the objectui#8617 claim sat in one paragraph, and correcting either alone would have left it asserting the same wrong thing.

If a claim did go false, correct the body. That is precedented and prose-only, frontmatter untouched; check-changeset-overwrite.mjs will report the correction as its own case 2 ("correcting a declaration on purpose … legitimate"), which is the intended shape — one gate asks for the read, the other records the write.

Not covered, stated so nobody reads this as more: a born-false claim that spells no line address at all (objectui#9495 coordinated one by ORDINAL — "a grep finds that member first" — and deciding that means reading what the sentence means), a claim spelled as a symbol or a package rather than a backticked file name, and a file named ambiguously.

Compared the checked-out tree with af57dc729 (merge-base with origin/main): 2 file(s) changed outside .changeset/, read against 1225 pending declaration(s) that publish a body (1787 pending in total). · run

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 329 chunks) 3058.7 KB 3104.5 KB
Main entry chunk (gzip) 146.9 KB 350 KB
Entry file index-d4g3HFBU.js
Status PASS

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 16.69KB 6.21KB
app-shell (runtime-config.js) 20.68KB 7.36KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.06KB 3.86KB
auth (ActiveOrganizationStorage.js) 25.05KB 9.16KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.18KB 10.59KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.15KB 5.39KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.65KB 2.22KB
auth (SocialSignInButtons.js) 9.61KB 3.89KB
auth (UserMenu.js) 3.41KB 1.23KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 40.21KB 10.80KB
auth (createAuthenticatedFetch.js) 8.46KB 3.43KB
auth (index.js) 3.19KB 1.44KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 26.08KB 7.56KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.49KB 2.64KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.68KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.05KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 545.92KB 130.72KB
core (index.js) 8.94KB 3.59KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 221.99KB 61.72KB
fields (index.js) 251.67KB 63.42KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 1.22KB 0.64KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.22KB 2.26KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 32.15KB 10.49KB
i18n (useDisplayLocale.js) 2.85KB 1.45KB
i18n (useObjectLabel.js) 34.34KB 9.17KB
i18n (useSafeTranslation.js) 5.60KB 2.33KB
layout (index.js) 38.90KB 10.97KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 13.52KB 4.88KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.24KB 2.16KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.39KB 3.10KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 14.81KB 3.63KB
plugin-calendar (index.js) 50.26KB 14.36KB
plugin-charts (index.js) 71.73KB 20.08KB
plugin-chatbot (index.js) 198.20KB 47.14KB
plugin-dashboard (index.js) 132.96KB 35.17KB
plugin-designer (index.js) 215.94KB 44.33KB
plugin-detail (index.js) 255.18KB 66.49KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 139.56KB 35.40KB
plugin-gantt (index.js) 167.62KB 41.26KB
plugin-grid (index.js) 213.44KB 58.21KB
plugin-kanban (index.js) 48.71KB 15.17KB
plugin-list (index.js) 113.53KB 27.99KB
plugin-map (index.js) 21.48KB 6.99KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 43.41KB 11.93KB
plugin-timeline (index.js) 30.68KB 8.95KB
plugin-tree (index.js) 10.58KB 3.72KB
plugin-view (index.js) 85.18KB 21.05KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.66KB 3.50KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 109.04KB 36.08KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.63KB 2.18KB
react (schema-input.js) 4.25KB 2.04KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.38KB 1.98KB
sdui-parser (codegen.js) 6.58KB 2.74KB
sdui-parser (dashboard-widget-options.js) 3.08KB 1.30KB
sdui-parser (index.js) 5.74KB 2.54KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (kanban-quick-add.js) 3.89KB 1.87KB
sdui-parser (parse.js) 25.28KB 7.80KB
sdui-parser (provenance.js) 3.66KB 1.82KB
sdui-parser (types.js) 0.28KB 0.23KB
sdui-parser (validate.js) 15.71KB 5.30KB
types (ai.js) 4.11KB 2.06KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 1.00KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 2.93KB 1.49KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 4.74KB 2.25KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 5.05KB 1.93KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 14.04KB 5.36KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.11KB 3.32KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-tesla
os-tesla marked this pull request as ready for review September 20, 2026 11:40
@os-tesla
os-tesla enabled auto-merge September 20, 2026 11:40
@os-tesla
os-tesla added this pull request to the merge queue Sep 20, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 20, 2026
@os-tesla
os-tesla added this pull request to the merge queue Sep 20, 2026
Merged via the queue into main with commit 8ed4b95 Sep 20, 2026
38 checks passed
@os-tesla
os-tesla deleted the claude/issue-9987-gantt-readme-navigation-view branch September 20, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation plugin tests

Projects

None yet

2 participants