fix(scripts): attribute the ci-cd-pipeline ledger's ci.yml control count to objectui#6400 - #7940
Merged
baozhoutao merged 1 commit intoSep 6, 2026
Conversation
…unt to objectui#6400 The version-claim ledger's `content/docs/guide/ci-cd-pipeline.md :: Node 22.x` entry (and its matching docblock bullet) said "28 mentions of ci.yml" as a control count for the sibling pin test, with no unit and no attribution. objectui#7034 found the file today holds 29 by occurrence count (`grep -o 'ci\.yml' | wc -l`). Re-measured: `grep -c 'ci\.yml'` (matching lines) still reads 28 today, matching what PR #6450 measured with the same command when it fixed objectui#6400 (its body shows `grep -c 'ci\.yml' ... -> 28 (control)`). So 28 was a line count from the moment it was written, not a drifted occurrence count — the ambiguity was the missing unit, not staleness. Disposition B per objectui#7034's triage: attribute the count to objectui#6400's cut and state its unit (lines, not occurrences), per the policy this file's own header already states for counts recording what a change measured when it landed. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013uAaxiwgYDybsTNV9xwa1M
baozhoutao
marked this pull request as ready for review
September 6, 2026 03:49
This was referenced Sep 6, 2026
baozhoutao
deleted the
claude/issue-7034-version-claim-ledger-control-count
branch
September 6, 2026 04:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7034
What changed
The version-claim ledger's
content/docs/guide/ci-cd-pipeline.md :: Node 22.xentry (scripts/__tests__/doc-version-claims.test.ts) carried a control count in two places — itswhystring and the matching docblock bullet — reading "28 mentions ofci.yml" with no unit and no attribution. objectui#7034 found the sibling pin test (ci-cd-pipeline-doc.test.ts) holds 29 by occurrence count today.Disposition B (per #7034's triage, adopting the card's own recommendation): attribute the count to the change that measured it, and state its unit.
Why 28 is the right number to keep (not re-take, not delete)
Re-measured on this branch:
The triage comment's finding: these two commands differ by exactly the line that carries
ci.ymltwice. That gave a testable hypothesis — the ledger's "28" was plausibly a line count from the start, not a number that drifted from 28 to 29.Confirmed against PR #6450 (the PR that implemented objectui#6400's disposition and wrote this exact sentence into the ledger). Its own PR body shows the command it ran:
grep -c— matching lines, not occurrences. So "28" has been a line count since it was written, and is still exactly 28 by that measure today. The ambiguity #7034 found was the missing UNIT, not staleness. Accordingly the two sentences now read "28 LINES matchingci.yml, as of objectui#6400 — not an occurrence count, which reads one higher" instead of naming a bare "29" that would itself need future re-verification.Diff
Both edits are in
scripts/__tests__/doc-version-claims.test.tsonly — the docblock bullet (~L415-419) and thewhystring of thecontent/docs/guide/ci-cd-pipeline.md :: Node 22.xKNOWN_CLAIMSentry (~L1040). No assertion, gate behaviour, or otherKNOWN_CLAIMSentry touched.Reverse verification
Tests / gates (all at final commit
7b34c3e7b)pnpm exec vitest run --maxWorkers=2 scripts/__tests__/doc-version-claims.test.ts scripts/__tests__/ci-cd-pipeline-doc.test.tspnpm type-check:scriptspnpm lint:rootpnpm check:control-bytesnode scripts/check-changeset-presence.mjsFiles changed: exactly 1 (
scripts/__tests__/doc-version-claims.test.ts), no changeset (not owed).Draft PR, no auto-merge — per this card's dispatch.
Generated by Claude Code