fix(docs): alert-dialog and sheet publish trigger/content as optional by baozhoutao · Pull Request #7944 · objectstack-ai/objectui

baozhoutao · 2026-09-06T04:01:38Z

What

alert-dialog.mdx:30 (trigger) and sheet.mdx:26 / :29 (trigger /
content) published these node slots as required. AlertDialogSchema
and SheetSchema (packages/types/src/overlay.ts) and their Zod mirrors
(zod/overlay.zod.ts) already declare all three optional — objectui#7073's
defect class (the pages refuse what the platform accepts), left on these two
pages after #7073 fenced itself to context-menu.mdx / dropdown-menu.mdx.

Fix is the mechanical one the card names: flip the three ?, no declaration
changes.

Pin file

The divergence was already machine-recorded in
packages/types/src/__tests__/overlay-node-slot-doc-types-7082.test.ts
(describe('requiredness divergences left to the objectui#7073 class …')).
Moved the three rows to the corrected/agreeing side, merged into the same
it.each as the ContextMenuSchema control #7073 already fixed, and updated
the file's top-of-file JSDoc note. Proved the coupling both ways:

Red (pages flipped, pin not yet updated): 3 failures, exactly the 3
target rows —
AlertDialogSchema.trigger / SheetSchema.trigger / SheetSchema.content
each failed expect(docRow(...).optional).toBe(false) (received true).
Green (pin updated to match): 33/33 passed.

Gates run locally

Gate	Result
`overlay-node-slot-doc-types-7082.test.ts` (vitest)	33/33 passed
`pnpm --filter @object-ui/types type-check`	exit 0 (`tsc --noEmit && tsc -p tsconfig.examples.json && tsc -p tsconfig.test.json`)
`node scripts/check-doc-fence-languages.mjs`	✅ every TS block fenced correctly
`node scripts/check-doc-component-types.mjs`	✅ every documented component type registered
`node scripts/check-doc-links.mjs`	✅ links valid across 17 scan roots
`node scripts/check-control-bytes.mjs`	✅ OK, 6408 tracked text files scanned
`node scripts/check-changeset-presence.mjs`	✅ empty-frontmatter changeset declared, `.changeset/overlay-slot-requiredness-7106.md`
`node scripts/check-governed-queue-guard.mjs --test <4 changed paths>`	✅ NOT GOVERNED — ordinary PR route

Scope

Only the three ? on the two pages, plus the pin-file move and an
empty-frontmatter changeset (docs-only, releases nothing). No declaration
changes (overlay.ts / zod/overlay.zod.ts untouched — they were already
correct). alert-dialog.mdx's deeper Schema-fence divergence (#7104) is
CLOSED and, measured on this branch's base, left these three rows untouched —
no entanglement remained, so both pages land in this one PR per PM ruling.

Generated by Claude Code

`alert-dialog.mdx:30` (trigger) and `sheet.mdx:26/:29` (trigger/content) published these node slots as required while AlertDialogSchema and SheetSchema (and their Zod mirrors) already declare them optional -- objectui#7073's defect class, left unaddressed on these two pages. Flip the three `?`. No declaration changes. Moves the three rows in overlay-node-slot-doc-types-7082.test.ts from "requiredness divergences" to the corrected/agreeing side, alongside the ContextMenuSchema control #7073 already fixed. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013uAaxiwgYDybsTNV9xwa1M

github-actions · 2026-09-06T04:05:44Z

✅ Console Performance Budget

Metric	Value	Budget
Eager closure (gzip, 50 chunks)	3187.4 KB	3191.4 KB
Main entry chunk (gzip)	143.5 KB	350 KB
Entry file	`index-DXVOmq-o.js`	—
Status	PASS	—

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (consoleActionDispatch.js)	0.20KB	0.19KB
app-shell (index.js)	15.67KB	5.75KB
app-shell (runtime-config.js)	20.68KB	7.36KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	10.06KB	3.86KB
auth (ActiveOrganizationStorage.js)	25.05KB	9.16KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	2.07KB	1.00KB
auth (AuthProvider.js)	40.18KB	10.59KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.21KB	3.45KB
auth (LoginForm.js)	18.15KB	5.39KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.65KB	2.22KB
auth (SocialSignInButtons.js)	9.61KB	3.89KB
auth (UserMenu.js)	3.41KB	1.23KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	40.21KB	10.80KB
auth (createAuthenticatedFetch.js)	8.46KB	3.43KB
auth (index.js)	3.19KB	1.44KB
auth (invitation-status.js)	1.22KB	0.70KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	5.30KB	1.02KB
auth (useWorkspaceAdminStatus.js)	5.13KB	2.35KB
collaboration (CommentThread.js)	26.08KB	7.56KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	6.49KB	2.64KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (index.js)	1.68KB	0.73KB
collaboration (useCollaborationTranslation.js)	6.05KB	2.52KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	510.60KB	116.20KB
core (index.js)	6.96KB	2.79KB
create-plugin (index.js)	10.08KB	3.26KB
data-objectstack (index.js)	182.08KB	50.62KB
fields (index.js)	242.44KB	61.25KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (builtinAggregateLabels.js)	0.86KB	0.49KB
i18n (currency.js)	1.22KB	0.64KB
i18n (fallbackInterpolation.js)	6.25KB	2.77KB
i18n (i18n.js)	4.28KB	1.75KB
i18n (index.js)	3.65KB	1.47KB
i18n (pickLocalized.js)	7.62KB	3.26KB
i18n (provider.js)	26.89KB	9.04KB
i18n (useDisplayLocale.js)	2.85KB	1.45KB
i18n (useObjectLabel.js)	34.34KB	9.17KB
i18n (useSafeTranslation.js)	5.60KB	2.33KB
layout (index.js)	38.98KB	10.98KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.75KB
mobile (index.js)	1.99KB	0.87KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.72KB	0.42KB
mobile (useSpecGesture.js)	4.39KB	1.66KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	11.71KB	4.29KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	6.24KB	2.16KB
permissions (discardProofCache.js)	1.04KB	0.55KB
permissions (evaluator.js)	5.12KB	1.74KB
permissions (index.js)	0.93KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.53KB
permissions (usePermissions.js)	4.83KB	2.27KB
plugin-ai (index.js)	15.75KB	3.80KB
plugin-calendar (index.js)	47.87KB	13.31KB
plugin-charts (index.js)	70.92KB	19.75KB
plugin-chatbot (index.js)	196.19KB	46.37KB
plugin-dashboard (index.js)	132.88KB	34.69KB
plugin-designer (index.js)	212.86KB	43.19KB
plugin-detail (index.js)	250.55KB	64.06KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	132.87KB	32.66KB
plugin-gantt (index.js)	167.26KB	41.00KB
plugin-grid (index.js)	209.29KB	56.78KB
plugin-kanban (index.js)	52.71KB	14.55KB
plugin-list (index.js)	113.56KB	27.70KB
plugin-map (index.js)	20.44KB	6.78KB
plugin-markdown (index.js)	13.93KB	4.81KB
plugin-report (index.js)	43.59KB	11.97KB
plugin-timeline (index.js)	30.40KB	8.76KB
plugin-tree (index.js)	9.20KB	3.19KB
plugin-view (index.js)	85.24KB	20.94KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	11.66KB	3.50KB
providers (index.js)	0.45KB	0.23KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.62KB	2.34KB
react (LazyPluginLoader.js)	4.47KB	1.63KB
react (SchemaRenderer.js)	81.07KB	26.86KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	4.63KB	2.18KB
react (schema-input.js)	2.32KB	1.24KB
react (spec-input.js)	0.20KB	0.18KB
sdui-parser (codegen.js)	5.41KB	2.34KB
sdui-parser (dashboard-widget-options.js)	3.08KB	1.30KB
sdui-parser (index.js)	4.93KB	2.24KB
sdui-parser (input-type.js)	2.84KB	1.40KB
sdui-parser (parse.js)	20.57KB	5.88KB
sdui-parser (provenance.js)	3.66KB	1.82KB
sdui-parser (types.js)	0.28KB	0.23KB
sdui-parser (validate.js)	10.35KB	3.60KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	1.00KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	2.74KB	1.41KB
types (crud.js)	0.20KB	0.18KB
types (dashboard-filter-alias.js)	6.23KB	2.74KB
types (data-display.js)	3.75KB	1.85KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.85KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (expression.js)	0.20KB	0.18KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (http-inflight.js)	8.87KB	3.73KB
types (http-retry.js)	4.32KB	2.02KB
types (icon-key-migration.js)	4.26KB	1.63KB
types (index.js)	4.74KB	2.25KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	4.73KB	2.28KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (select-option.js)	0.20KB	0.19KB
types (spec-report.js)	5.05KB	1.93KB
types (spec-ui-namespace.js)	0.20KB	0.19KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	6.28KB	2.87KB
types (ui-action.js)	8.11KB	3.32KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

github-actions Bot added package: types tests labels Sep 6, 2026

baozhoutao marked this pull request as ready for review September 6, 2026 04:03

claude Bot mentioned this pull request Sep 6, 2026

finding(docs): alert-dialog.mdx and sheet.mdx publish three node slots as REQUIRED that the shipped types declare OPTIONAL — the rows #7073 corrected on the third menu page #7106

Closed

baozhoutao added this pull request to the merge queue Sep 6, 2026

Merged via the queue into main with commit b0af6cf Sep 6, 2026
34 checks passed

baozhoutao deleted the claude/issue-7106-overlay-slot-requiredness branch September 6, 2026 04:39

Navigation Menu

Uh oh!

fix(docs): alert-dialog and sheet publish trigger/content as optional - #7944

fix(docs): alert-dialog and sheet publish trigger/content as optional#7944
baozhoutao merged 1 commit into
mainfrom
claude/issue-7106-overlay-slot-requiredness

baozhoutao commented Sep 6, 2026

Uh oh!

github-actions Bot commented Sep 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

baozhoutao commented Sep 6, 2026

What

Pin file

Gates run locally

Scope

Uh oh!

github-actions Bot commented Sep 6, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants