test(app-shell,scripts): plugin-charts and plugin-dashboard join COVERED_SPECIFIERS (objectui#6892 slice 2)

[claude]

Part of #6892

The second slice of the vi.mock inheritance worklist: @object-ui/plugin-charts (1 site) and @object-ui/plugin-dashboard (3 sites). Each factory now obtains the real module and spreads it before its own overrides, and both specifiers join COVERED_SPECIFIERS in the same PR — the widening precondition the gate's own header states, and the one objectui#6849's ruling forbids splitting.

Verified at 35a32c092, on base 689127723 (which carries slice 1, PR #8020).

⚠️ Angle brackets are written out in words below. GitHub's body sanitizer eats angle-bracket-shaped tokens, including inside backticks and fenced blocks (AGENTS.md, "GitHub 会改写你写进 issue/PR 正文的字节"). The generic argument that appears literally in the source is written here as GENERIC-RECORD, and it stands for a Record mapping string to unknown.

Re-derived per-specifier table — ⛔ not the card's

The card's table (9ce20233f) is stale three ways now, and the third one is new to this slice:

1. it predates the recogniser repair in PR test(app-shell,console): 29 @object-ui/i18n mock factories inherit the real surface, and the recogniser stops mis-reading a nested generic (objectui#7337) #7889 (the old classifier over-reported frozen);
2. it predates the @object-ui/i18n flip (PR test(app-shell,scripts): @object-ui/i18n joins COVERED_SPECIFIERS (objectui#7337) #7920) and slice 1 (PR test(console,app-shell,scripts): three 1-site specifiers join COVERED_SPECIFIERS (objectui#6892 slice 1) #8020);
3. ⭐ its population has GROWN under it. @object-ui/plugin-charts is not on that table at all — not because the classifier hid it, but because its only call site did not exist yet. ObjectView.chartConfigForward-7891.test.tsx was added by 38158c6bb on 2026-09-06, a week after the 9ce20233f snapshot of 2026-08-30. Measured with a two-leg check: git cat-file -e 9ce20233f:PATH exits 128 for that file and 0 for a control path that resolves at the same commit. A slice scoped from the table alone would have swept @object-ui/plugin-dashboard, flipped both lines, and left a frozen site behind on the specifier it had just declared covered.

Everything below was measured on this branch with the repaired classifier, by slice 1's method: scan() is exported and takes a covered option, so the table comes from a scratchpad script and the constant in the tree was never widened-and-reverted.

import { scan } from './scripts/check-vi-mock-inherit.mjs';
const probe = scan(root, { covered: [] });                     // pass 1: name every workspace specifier
const specs = [...new Set(probe.sites.filter((s) => s.scope === 'workspace').map((s) => s.specifier))];
const all = scan(root, { covered: specs, floors: {} });        // pass 2: judge them all

This slice's two, before and after:

specifier	judged	inherits before	frozen before	inherits after	frozen after
@object-ui/plugin-charts	1	0	1	1	0
@object-ui/plugin-dashboard	3	0	3	3	0

The whole population, over the 22 workspace specifiers any call site in the tree names:

	before	after
judged call sites	640	640
inheriting	325	329
frozen	315	311
unreadable / indirect	0	0

Zero sites moved the other way, and this is a measurement rather than a claim: the per-specifier rows for the other 20 specifiers are byte-identical between the two runs (diff of the two tables with the two changed rows removed exits 0).

The remaining 311 stay on the worklist. @object-ui/auth at 102 is the largest by yield; @object-ui/app-shell at 23 still reads #6580 first.

The conversion, per file

All four take the shape already used by their neighbours — ObjectView.chartConfigForward-7891.test.tsx has a @object-ui/plugin-view factory two lines below that is line-for-line this spelling, and ReportView.dataSourceObjectKey.test.tsx has the @object-ui/plugin-report factory slice 1 converted immediately above. The spread is the first property in all four, so every test's own stub still shadows the real export exactly as before.

file	line	specifier	what the factory overrides
packages/app-shell/src/views/ObjectView.chartConfigForward-7891.test.tsx	115	@object-ui/plugin-charts	ObjectChart, ChartRenderer
packages/app-shell/src/views/DashboardView.modalTarget.test.tsx	51	@object-ui/plugin-dashboard	DashboardRenderer
packages/app-shell/src/views/DashboardView.rootTitleRetired.test.tsx	45	@object-ui/plugin-dashboard	DashboardRenderer
packages/app-shell/src/views/ReportView.dataSourceObjectKey.test.tsx	67	@object-ui/plugin-dashboard	DrillDownDrawer

None of the four is a deliberate freeze. Each was read against the "prove the module is NOT loaded" shape the gate's header carves out, and each is an ordinary stub-the-renderer factory that captures props and asserts on them. DrillDownDrawer is a bare null-returning stub, but the file never asserts that it was absent — its two null assertions are about a query record, not about an export.

Behaviour preservation

Spreading the real module means each mock now returns exports it previously omitted, so this was checked rather than assumed, on PR #6847's criteria:

1. Nothing can observe the mock's key set. A repo-wide search for a namespace import of either specifier returns zero hits, against a control search that returns 249 files — so there is no namespace object for an Object.keys or in test to read.
2. No absence assertion is about the mocked module. Every absence assertion in the four files was read: they are about captured props, about a captured query record, and about the DOM. None is about an export.
3. Overrides still win — the spread is the first property in all four.
4. Both specifiers resolve to src/, not dist/. The root vitest.config.mts aliases @object-ui/plugin-charts and @object-ui/plugin-dashboard to their package src/, so the real module is read from source and no build stands between the edit and the run.

⭐ One real behavioural difference, recorded rather than glossed. Unlike slice 1's three, both of these barrels have module-scope side effects: packages/plugin-charts/src/index.tsx and packages/plugin-dashboard/src/index.tsx each make 8 ComponentRegistry.register calls. Inheriting means those calls now run in these four files, where the frozen factory used to suppress them. The suite is green either way, and the cost is not measurable: the four files together ran 28.99s frozen and 29.88s inheriting.

DashboardView.modalTarget.test.tsx carried a comment claiming the stub "keeps this file out of the ComponentRegistry-heavy setup". That sentence is false after this change, so it is corrected in the same commit rather than left to mislead the next reader — the only edit in this PR that is not a factory or a constant.

Reverse verification — two legs, four times

Committed first, then mutated: the restore leg points at HEAD, and HEAD carries the implementation. Each leg proves itself on disk — the mutation by counting the deleted spread marker and the injected frozen form, the restore by git hash-object equal to the HEAD blob and an empty git diff HEAD. Restore runs from a trap on EXIT INT TERM with absolute paths built from git rev-parse --show-toplevel.

Leg A — re-freeze one factory, keep its specifier covered. The gate goes RED, exit 1, naming that site and no other (four separate runs; the "total site lines reported" count was 1 each time, so the red is precise, not a shower):

- packages/app-shell/src/views/ObjectView.chartConfigForward-7891.test.tsx:115 -- vi.mock("@object-ui/plugin-charts")
- packages/app-shell/src/views/DashboardView.modalTarget.test.tsx:51 -- vi.mock("@object-ui/plugin-dashboard")
- packages/app-shell/src/views/DashboardView.rootTitleRetired.test.tsx:45 -- vi.mock("@object-ui/plugin-dashboard")
- packages/app-shell/src/views/ReportView.dataSourceObjectKey.test.tsx:67 -- vi.mock("@object-ui/plugin-dashboard")

each with the factory never obtains the real module.

Leg B — restore. Blobs a278550d7, 2e4cab260, 291f2981b, d066f8194, each equal to HEAD's, git diff HEAD empty, gate exit 0 each time.

This is what makes the two new COVERED_SPECIFIERS lines load-bearing rather than decorative: without them Leg A stays green, because an unlisted specifier is never judged. The whole ablation was re-run at the final HEAD after the comment correction moved one blob, so none of the hashes above is stale.

The guard's own pin needed no edit

Expected to redden and did not, so it is recorded rather than assumed — same as slice 1. Every membership assertion in scripts/__tests__/check-vi-mock-inherit.test.ts is derived from the constant rather than spelling it, and both new members resolve to a real packages/NAME/package.json, so all 69 cases pass unchanged.

The flip side of that derivation is filed separately as #8018 and is not addressed here: the only membership pin that resists removal names @object-ui/i18n alone.

Gates

All at 35a32c092, exit codes captured by redirect-then-capture (never through a pipe).

gate	exit	reading
pnpm check:vi-mock-inherit	0	233 call site(s) on @object-ui/react, @object-ui/i18n, @object-ui/plugin-markdown, @object-ui/data-objectstack, @object-ui/plugin-report, @object-ui/plugin-charts, @object-ui/plugin-dashboard judged (233 inherit, 0 auto-mocked) — was 229 on five
vitest run scripts/__tests__/check-vi-mock-inherit.test.ts + the 4 converted files	0	Test Files 5 passed (5), Tests 89 passed (89) (69 pin + 20 converted)
vitest run packages/app-shell/	0	Test Files 632 passed (632), `Tests 6077 passed
pnpm check:vi-mock-specifiers	0	OK (4356 tracked source file(s) ... 868 relative specifier(s) resolved)
pnpm type-check:scripts	0	clean tsc -p tsconfig.scripts.json
pnpm check:control-bytes	0	OK (scanned 6448 tracked text file(s); skipped 85 binary)
grep -naP control-byte self-scan of all 6 changed paths	1	no match — clean
node scripts/check-changeset-presence.mjs	0	4 source file(s) of 1 released package(s) changed ... Every one of them has an EMPTY frontmatter
check-changeset-fixed / -no-major / -overwrite	0	each
check-lint-coverage.mjs	0	46/46 packages linted, 0 with outstanding errors
node scripts/check-governed-queue-guard.mjs --test (all 6 paths)	0	NOT GOVERNED — 6 path(s) checked against 5 governed surface(s); none matched
app-shell tsc --noEmit (src)	0	clean
app-shell tsc -p tsconfig.test.json	0	non-vacuous: --listFiles program of 4421 files names all four edited test files (1 hit each)
app-shell eslint . (full, not narrowed)	0	1087 files, 0 errors; all four edited files present in --format json; 0 warnings on any added line (the 4/13/6/7 warnings on those files are pre-existing no-explicit-any on their own any-typed props)

The changeset declares an empty frontmatter: the four edited files are test files under a released package's src/, and nothing published changes. objectui has no skip-changeset label, so this is the whole answer to that gate.

Scope of "affected" was derived, not guessed. TURBO_SCM_BASE=689127723 turbo ls --affected names four packages: app-shell (run in full above) plus console, example-byo-backend-console and example-console-starter, which the dependency graph pulls in. Those three are declared to CI rather than run here, on a reachability check: nothing outside packages/app-shell references any of the four edited test files (one hit, a comment inside app-shell itself, against a control search returning 9 files), and a .test.tsx edit cannot be imported by another package. The dependency closure had to be built before the type-check meant anything — the first run showed 1279 TS2307s that were the unbuilt closure, not the diff; after pnpm --filter '@object-ui/app-shell^...' build both swept packages' dist/index.d.ts carry this worktree's own build timestamps, so the type-check read local artifacts rather than a replayed foreign cache.

Live E2E (informational) is red on every branch today for an upstream reason (#7990 / objectstack#16186) and is not this PR's.

---

Generated by Claude Code

[github-actions]

✅ Console Performance Budget

Metric	Value	Budget
Eager closure (gzip, 50 chunks)	3186.0 KB	3191.4 KB
Main entry chunk (gzip)	143.5 KB	350 KB
Entry file	index-BO0uFEv5.js	—
Status	PASS	—

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.

---

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (consoleActionDispatch.js)	0.20KB	0.19KB
app-shell (index.js)	15.67KB	5.75KB
app-shell (runtime-config.js)	20.68KB	7.36KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	10.06KB	3.86KB
auth (ActiveOrganizationStorage.js)	25.05KB	9.16KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	2.07KB	1.00KB
auth (AuthProvider.js)	40.18KB	10.59KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.21KB	3.45KB
auth (LoginForm.js)	18.15KB	5.39KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.65KB	2.22KB
auth (SocialSignInButtons.js)	9.61KB	3.89KB
auth (UserMenu.js)	3.41KB	1.23KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	40.21KB	10.80KB
auth (createAuthenticatedFetch.js)	8.46KB	3.43KB
auth (index.js)	3.19KB	1.44KB
auth (invitation-status.js)	1.22KB	0.70KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	5.30KB	1.02KB
auth (useWorkspaceAdminStatus.js)	5.13KB	2.35KB
collaboration (CommentThread.js)	26.08KB	7.56KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	6.49KB	2.64KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (index.js)	1.68KB	0.73KB
collaboration (useCollaborationTranslation.js)	6.05KB	2.52KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	497.06KB	113.79KB
core (index.js)	6.96KB	2.79KB
create-plugin (index.js)	10.08KB	3.26KB
data-objectstack (index.js)	182.08KB	50.62KB
fields (index.js)	242.44KB	61.25KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (builtinAggregateLabels.js)	0.86KB	0.49KB
i18n (currency.js)	1.22KB	0.64KB
i18n (fallbackInterpolation.js)	6.25KB	2.77KB
i18n (i18n.js)	4.28KB	1.75KB
i18n (index.js)	3.65KB	1.47KB
i18n (pickLocalized.js)	7.62KB	3.26KB
i18n (provider.js)	26.89KB	9.04KB
i18n (useDisplayLocale.js)	2.85KB	1.45KB
i18n (useObjectLabel.js)	34.34KB	9.17KB
i18n (useSafeTranslation.js)	5.60KB	2.33KB
layout (index.js)	38.84KB	10.94KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.75KB
mobile (index.js)	1.99KB	0.87KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.72KB	0.42KB
mobile (useSpecGesture.js)	4.39KB	1.66KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	11.71KB	4.29KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	6.24KB	2.16KB
permissions (discardProofCache.js)	1.04KB	0.55KB
permissions (evaluator.js)	5.12KB	1.74KB
permissions (index.js)	0.93KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.53KB
permissions (usePermissions.js)	4.83KB	2.27KB
plugin-ai (index.js)	15.16KB	3.68KB
plugin-calendar (index.js)	47.35KB	13.21KB
plugin-charts (index.js)	70.31KB	19.62KB
plugin-chatbot (index.js)	193.53KB	46.05KB
plugin-dashboard (index.js)	131.41KB	34.43KB
plugin-designer (index.js)	211.51KB	43.01KB
plugin-detail (index.js)	247.59KB	63.48KB
plugin-editor (index.js)	2.23KB	1.05KB
plugin-form (index.js)	131.01KB	32.32KB
plugin-gantt (index.js)	167.16KB	40.99KB
plugin-grid (index.js)	208.56KB	56.63KB
plugin-kanban (index.js)	52.30KB	14.49KB
plugin-list (index.js)	113.24KB	27.66KB
plugin-map (index.js)	20.35KB	6.77KB
plugin-markdown (index.js)	13.88KB	4.80KB
plugin-report (index.js)	43.42KB	11.92KB
plugin-timeline (index.js)	29.95KB	8.67KB
plugin-tree (index.js)	9.16KB	3.18KB
plugin-view (index.js)	84.33KB	20.75KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	11.66KB	3.50KB
providers (index.js)	0.45KB	0.23KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.62KB	2.34KB
react (LazyPluginLoader.js)	4.47KB	1.63KB
react (SchemaRenderer.js)	81.07KB	26.86KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	4.63KB	2.18KB
react (schema-input.js)	2.32KB	1.24KB
react (spec-input.js)	0.20KB	0.18KB
sdui-parser (codegen.js)	5.41KB	2.34KB
sdui-parser (dashboard-widget-options.js)	3.08KB	1.30KB
sdui-parser (index.js)	4.93KB	2.24KB
sdui-parser (input-type.js)	2.84KB	1.40KB
sdui-parser (parse.js)	20.57KB	5.88KB
sdui-parser (provenance.js)	3.66KB	1.82KB
sdui-parser (types.js)	0.28KB	0.23KB
sdui-parser (validate.js)	10.35KB	3.60KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	1.00KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	2.74KB	1.41KB
types (crud.js)	0.20KB	0.18KB
types (dashboard-filter-alias.js)	6.23KB	2.74KB
types (data-display.js)	3.75KB	1.85KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.85KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (expression.js)	0.20KB	0.18KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (http-inflight.js)	8.87KB	3.73KB
types (http-retry.js)	4.32KB	2.02KB
types (icon-key-migration.js)	4.26KB	1.63KB
types (index.js)	4.74KB	2.25KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	4.73KB	2.28KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (select-option.js)	0.20KB	0.19KB
types (spec-report.js)	5.05KB	1.93KB
types (spec-ui-namespace.js)	0.20KB	0.19KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	6.28KB	2.87KB
types (ui-action.js)	8.11KB	3.32KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

• ✅ Core packages should be < 50KB gzipped
• ✅ Component packages should be < 100KB gzipped
• ⚠️ Plugin packages should be < 150KB gzipped

[baozhoutao]

Standing-down note — Live E2E (informational) is red on main and on every branch today: the upstream base-red anchored on #7990 (objectstack#16186). It is continue-on-error by design, never blocks the queue, and touches nothing this diff changes (four vi.mock factories, two lines of COVERED_SPECIFIERS, one empty changeset). Not this PR's to fix; no re-run requested. ACCEPTed on the card (#6892); flip and arming follow once the remaining checks conclude.

---

Generated by Claude Code