Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/vi-mock-inherit-slice8-permissions.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
---

Test-only change: 24 `vi.mock('@object-ui/permissions', ...)` factories now inherit
the real module's export surface instead of freezing a hand-listed one, and the
specifier joins `COVERED_SPECIFIERS` in `scripts/check-vi-mock-inherit.mjs`. No
published behaviour changes.
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,13 @@ let permissionsState: {
can: (objectName: string, action: string) => boolean;
hasCapabilities: (caps: string[]) => boolean;
};
vi.mock('@object-ui/permissions', () => ({
usePermissions: () => permissionsState,
}));
vi.mock('@object-ui/permissions', async (importOriginal) => {
const actual = await importOriginal<typeof import('@object-ui/permissions')>();
return {
...actual,
usePermissions: () => permissionsState,
};
});

let metadataState: { apps: unknown[]; objects: unknown[] };
vi.mock('../../providers/MetadataProvider', () => ({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,13 @@ let permissionsState: {
can: (objectName: string, action: string) => boolean;
hasCapabilities: (caps: string[]) => boolean;
};
vi.mock('@object-ui/permissions', () => ({
usePermissions: () => permissionsState,
}));
vi.mock('@object-ui/permissions', async (importOriginal) => {
const actual = await importOriginal<typeof import('@object-ui/permissions')>();
return {
...actual,
usePermissions: () => permissionsState,
};
});

let metadataState: { apps: unknown[]; objects: unknown[] };
vi.mock('../../providers/MetadataProvider', () => ({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,13 @@ vi.mock('@object-ui/auth', async (importOriginal) => ({
getUserInitials: () => 'U',
}));

vi.mock('@object-ui/permissions', () => ({
usePermissions: () => ({ can: () => true, hasCapabilities: () => true }),
}));
vi.mock('@object-ui/permissions', async (importOriginal) => {
const actual = await importOriginal<typeof import('@object-ui/permissions')>();
return {
...actual,
usePermissions: () => ({ can: () => true, hasCapabilities: () => true }),
};
});

/** The zero-app deployment both senders exist for. */
vi.mock('../../providers/MetadataProvider', () => ({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,13 @@ vi.mock('@object-ui/auth', async (importOriginal) => ({
getUserInitials: () => 'U',
}));

vi.mock('@object-ui/permissions', () => ({
usePermissions: () => ({ can: () => true, hasCapabilities: () => true }),
}));
vi.mock('@object-ui/permissions', async (importOriginal) => {
const actual = await importOriginal<typeof import('@object-ui/permissions')>();
return {
...actual,
usePermissions: () => ({ can: () => true, hasCapabilities: () => true }),
};
});

/** The zero-app deployment `systemFallbackNavigation` exists for. */
vi.mock('../../providers/MetadataProvider', () => ({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,13 @@ vi.mock('@object-ui/auth', async (importOriginal) => ({
getUserInitials: () => 'U',
}));

vi.mock('@object-ui/permissions', () => ({
usePermissions: () => ({ can: () => true, hasCapabilities: () => true }),
}));
vi.mock('@object-ui/permissions', async (importOriginal) => {
const actual = await importOriginal<typeof import('@object-ui/permissions')>();
return {
...actual,
usePermissions: () => ({ can: () => true, hasCapabilities: () => true }),
};
});

/** The zero-app deployment `systemFallbackNavigation` exists for. */
vi.mock('../../providers/MetadataProvider', () => ({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,13 @@ vi.mock('@object-ui/auth', async (importOriginal) => ({
getUserInitials: () => 'U',
}));

vi.mock('@object-ui/permissions', () => ({
usePermissions: () => ({ can: () => true, hasCapabilities: () => true }),
}));
vi.mock('@object-ui/permissions', async (importOriginal) => {
const actual = await importOriginal<typeof import('@object-ui/permissions')>();
return {
...actual,
usePermissions: () => ({ can: () => true, hasCapabilities: () => true }),
};
});

/** The zero-app deployment this whole screen exists for. */
vi.mock('../../providers/MetadataProvider', () => ({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,21 +62,25 @@ let principal: Record<string, boolean> = {};
/** Controllable server-resolved effective API operations (#3391); `undefined` = unrestricted. */
let apiOperations: string[] | undefined;

vi.mock('@object-ui/permissions', () => ({
usePermissions: () => ({
check: () => ({ allowed: true }),
checkField: () => true,
getFieldPermissions: () => [],
getRowFilter: () => undefined,
getObjectApiOperations: () => apiOperations,
roles: [],
isLoaded: false,
hasCapabilities: () => true,
can: (_object: string, action: string) => principal[action] ?? true,
cannot: (_object: string, action: string) => !(principal[action] ?? true),
}),
useFieldPermissions: () => ({ canRead: () => true, canWrite: () => true, permissions: [] }),
}));
vi.mock('@object-ui/permissions', async (importOriginal) => {
const actual = await importOriginal<typeof import('@object-ui/permissions')>();
return {
...actual,
usePermissions: () => ({
check: () => ({ allowed: true }),
checkField: () => true,
getFieldPermissions: () => [],
getRowFilter: () => undefined,
getObjectApiOperations: () => apiOperations,
roles: [],
isLoaded: false,
hasCapabilities: () => true,
can: (_object: string, action: string) => principal[action] ?? true,
cannot: (_object: string, action: string) => !(principal[action] ?? true),
}),
useFieldPermissions: () => ({ canRead: () => true, canWrite: () => true, permissions: [] }),
};
});

vi.mock('@object-ui/auth', async (importOriginal) => ({
...(await importOriginal<Record<string, unknown>>()),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,21 +71,25 @@ import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
import { render, cleanup, waitFor } from '@testing-library/react';
import { MemoryRouter, Routes, Route } from 'react-router-dom';

vi.mock('@object-ui/permissions', () => ({
usePermissions: () => ({
check: () => ({ allowed: true }),
checkField: () => true,
getFieldPermissions: () => [],
getRowFilter: () => undefined,
getObjectApiOperations: () => undefined,
roles: [],
isLoaded: false,
hasCapabilities: () => true,
can: () => true,
cannot: () => false,
}),
useFieldPermissions: () => ({ canRead: () => true, canWrite: () => true, permissions: [] }),
}));
vi.mock('@object-ui/permissions', async (importOriginal) => {
const actual = await importOriginal<typeof import('@object-ui/permissions')>();
return {
...actual,
usePermissions: () => ({
check: () => ({ allowed: true }),
checkField: () => true,
getFieldPermissions: () => [],
getRowFilter: () => undefined,
getObjectApiOperations: () => undefined,
roles: [],
isLoaded: false,
hasCapabilities: () => true,
can: () => true,
cannot: () => false,
}),
useFieldPermissions: () => ({ canRead: () => true, canWrite: () => true, permissions: [] }),
};
});

vi.mock('@object-ui/auth', async (importOriginal) => ({
...(await importOriginal<Record<string, unknown>>()),
Expand Down
34 changes: 19 additions & 15 deletions packages/app-shell/src/views/ObjectView.chartRelay-7823.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -90,21 +90,25 @@ import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
import { render, cleanup, waitFor, screen, fireEvent } from '@testing-library/react';
import { MemoryRouter, Routes, Route } from 'react-router-dom';

vi.mock('@object-ui/permissions', () => ({
usePermissions: () => ({
check: () => ({ allowed: true }),
checkField: () => true,
getFieldPermissions: () => [],
getRowFilter: () => undefined,
getObjectApiOperations: () => undefined,
roles: [],
isLoaded: false,
hasCapabilities: () => true,
can: () => true,
cannot: () => false,
}),
useFieldPermissions: () => ({ canRead: () => true, canWrite: () => true, permissions: [] }),
}));
vi.mock('@object-ui/permissions', async (importOriginal) => {
const actual = await importOriginal<typeof import('@object-ui/permissions')>();
return {
...actual,
usePermissions: () => ({
check: () => ({ allowed: true }),
checkField: () => true,
getFieldPermissions: () => [],
getRowFilter: () => undefined,
getObjectApiOperations: () => undefined,
roles: [],
isLoaded: false,
hasCapabilities: () => true,
can: () => true,
cannot: () => false,
}),
useFieldPermissions: () => ({ canRead: () => true, canWrite: () => true, permissions: [] }),
};
});

vi.mock('@object-ui/auth', async (importOriginal) => ({
...(await importOriginal<Record<string, unknown>>()),
Expand Down
34 changes: 19 additions & 15 deletions packages/app-shell/src/views/ObjectView.createPredicates.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -54,21 +54,25 @@ import { MemoryRouter, Routes, Route } from 'react-router-dom';
/** Controllable principal verdict, keyed by action (`can()` is permissive by default). */
let principal: Record<string, boolean> = {};

vi.mock('@object-ui/permissions', () => ({
usePermissions: () => ({
check: () => ({ allowed: true }),
checkField: () => true,
getFieldPermissions: () => [],
getRowFilter: () => undefined,
getObjectApiOperations: () => undefined,
roles: [],
isLoaded: false,
hasCapabilities: () => true,
can: (_object: string, action: string) => principal[action] ?? true,
cannot: (_object: string, action: string) => !(principal[action] ?? true),
}),
useFieldPermissions: () => ({ canRead: () => true, canWrite: () => true, permissions: [] }),
}));
vi.mock('@object-ui/permissions', async (importOriginal) => {
const actual = await importOriginal<typeof import('@object-ui/permissions')>();
return {
...actual,
usePermissions: () => ({
check: () => ({ allowed: true }),
checkField: () => true,
getFieldPermissions: () => [],
getRowFilter: () => undefined,
getObjectApiOperations: () => undefined,
roles: [],
isLoaded: false,
hasCapabilities: () => true,
can: (_object: string, action: string) => principal[action] ?? true,
cannot: (_object: string, action: string) => !(principal[action] ?? true),
}),
useFieldPermissions: () => ({ canRead: () => true, canWrite: () => true, permissions: [] }),
};
});

vi.mock('@object-ui/auth', async (importOriginal) => ({
...(await importOriginal<Record<string, unknown>>()),
Expand Down
34 changes: 19 additions & 15 deletions packages/app-shell/src/views/ObjectView.importPredicates.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -45,21 +45,25 @@ import { MemoryRouter, Routes, Route } from 'react-router-dom';
/** Controllable principal verdict, keyed by action (`can()` is permissive by default). */
let principal: Record<string, boolean> = {};

vi.mock('@object-ui/permissions', () => ({
usePermissions: () => ({
check: () => ({ allowed: true }),
checkField: () => true,
getFieldPermissions: () => [],
getRowFilter: () => undefined,
getObjectApiOperations: () => undefined,
roles: [],
isLoaded: false,
hasCapabilities: () => true,
can: (_object: string, action: string) => principal[action] ?? true,
cannot: (_object: string, action: string) => !(principal[action] ?? true),
}),
useFieldPermissions: () => ({ canRead: () => true, canWrite: () => true, permissions: [] }),
}));
vi.mock('@object-ui/permissions', async (importOriginal) => {
const actual = await importOriginal<typeof import('@object-ui/permissions')>();
return {
...actual,
usePermissions: () => ({
check: () => ({ allowed: true }),
checkField: () => true,
getFieldPermissions: () => [],
getRowFilter: () => undefined,
getObjectApiOperations: () => undefined,
roles: [],
isLoaded: false,
hasCapabilities: () => true,
can: (_object: string, action: string) => principal[action] ?? true,
cannot: (_object: string, action: string) => !(principal[action] ?? true),
}),
useFieldPermissions: () => ({ canRead: () => true, canWrite: () => true, permissions: [] }),
};
});

vi.mock('@object-ui/auth', async (importOriginal) => ({
...(await importOriginal<Record<string, unknown>>()),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,22 +76,26 @@ import { MemoryRouter, Routes, Route } from 'react-router-dom';
*/
let heldCapabilities: string[] | undefined;

vi.mock('@object-ui/permissions', () => ({
usePermissions: () => ({
systemPermissions: heldCapabilities,
check: () => ({ allowed: true }),
checkField: () => true,
getFieldPermissions: () => [],
getRowFilter: () => undefined,
getObjectApiOperations: () => undefined,
roles: [],
isLoaded: true,
hasCapabilities: () => true,
can: () => true,
cannot: () => false,
}),
useFieldPermissions: () => ({ canRead: () => true, canWrite: () => true, permissions: [] }),
}));
vi.mock('@object-ui/permissions', async (importOriginal) => {
const actual = await importOriginal<typeof import('@object-ui/permissions')>();
return {
...actual,
usePermissions: () => ({
systemPermissions: heldCapabilities,
check: () => ({ allowed: true }),
checkField: () => true,
getFieldPermissions: () => [],
getRowFilter: () => undefined,
getObjectApiOperations: () => undefined,
roles: [],
isLoaded: true,
hasCapabilities: () => true,
can: () => true,
cannot: () => false,
}),
useFieldPermissions: () => ({ canRead: () => true, canWrite: () => true, permissions: [] }),
};
});

vi.mock('@object-ui/auth', async (importOriginal) => ({
...(await importOriginal<Record<string, unknown>>()),
Expand Down
34 changes: 19 additions & 15 deletions packages/app-shell/src/views/ObjectView.rowColorRelay-7218.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -86,21 +86,25 @@ import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
import { render, cleanup, waitFor } from '@testing-library/react';
import { MemoryRouter, Routes, Route } from 'react-router-dom';

vi.mock('@object-ui/permissions', () => ({
usePermissions: () => ({
check: () => ({ allowed: true }),
checkField: () => true,
getFieldPermissions: () => [],
getRowFilter: () => undefined,
getObjectApiOperations: () => undefined,
roles: [],
isLoaded: false,
hasCapabilities: () => true,
can: () => true,
cannot: () => false,
}),
useFieldPermissions: () => ({ canRead: () => true, canWrite: () => true, permissions: [] }),
}));
vi.mock('@object-ui/permissions', async (importOriginal) => {
const actual = await importOriginal<typeof import('@object-ui/permissions')>();
return {
...actual,
usePermissions: () => ({
check: () => ({ allowed: true }),
checkField: () => true,
getFieldPermissions: () => [],
getRowFilter: () => undefined,
getObjectApiOperations: () => undefined,
roles: [],
isLoaded: false,
hasCapabilities: () => true,
can: () => true,
cannot: () => false,
}),
useFieldPermissions: () => ({ canRead: () => true, canWrite: () => true, permissions: [] }),
};
});

vi.mock('@object-ui/auth', async (importOriginal) => ({
...(await importOriginal<Record<string, unknown>>()),
Expand Down
Loading
Loading