docs(scripts,ci): two drifted counts become the relation and a dated reading (objectui#8122) - #8462
Conversation
…reading (objectui#8122) `check-shell-escape-residue`'s docblock said "the other four roots still return 203 of today's 207 files" while the same run's own verdict line prints 206 files (1310 fenced blocks today). The paragraph's argument is a RELATION -- a per-root floor survives one root reading zero, a total floor does not -- so the numerals bought nothing; the sentence now states the relation and names `summarise()`, whose verdict line is where a reader takes the live population. `changeset-release.yml`'s post-version step table said `pnpm test scripts/__tests__ 73 files / 1996 tests`. Re-measured on this branch's base: 121 files / 3618 tests. It was not true at the block's own declared measurement date either -- `main` carried 81 test files on 2026-08-25. The column now names the directory; the drift itself is recorded with its measurement point, and the wall-clock readings that justified the scoping decision are dated rather than restated as today's. No behaviour, no floor, no scan population moves: `minFiles: 3` and every `SCAN_ROOTS` row are untouched, and both files change only comments. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FhBNJcLRZLe8M87VcUgpKr
|
What failed in the groupGroup This PR's entire diff is two comment blocks — one in ⭐ The discrimination, measured rather than argued⛔ "It can't be mine" is not a root cause, so the window was narrowed with a control:
⇒ The failure entered between ⛔ This seat does not name which. The failing test unwraps through What this seat is doing about it
⛔ Nothing about this PR needs changing meanwhile: no rebase, no changes requested, no force-push. The head that was green is the head that will be re-queued. Generated by Claude Code |
|
LANDED —
⇒ That is the dated historical form — precisely the shape this card exists to produce. A probe string that cannot tell "the live column says X" from "the column used to say X, and here is when it stopped" is asking the wrong question. Same lesson as #8461's docblock false hit an hour ago: a raw grep over a whole file cannot answer a question that is about one region of it.
Generated by Claude Code |
Fixes #8122
Comments only, in two files. No behaviour, no floor, no scan population moves:
minFiles: 3and everySCAN_ROOTSrow are byte-identical, andchangeset-release.yml's step list below the header is untouched.Re-derived first, on this branch's base (
1706d8be4), not on the card's commit59a3a233d)1706d8be4)check-shell-escape-residuepopulationpnpm test scripts/__tests__Both defects reproduce, and site 2 is worse than the card says:
73 fileswas never true at the measurement date its own block declares —maincarried 81 test files on 2026-08-25 (git ls-tree -r --name-only 129c7a9e7 scripts/__tests__ | grep -c '\.test\.'). The card's own figures had already drifted in the two days between filing and this branch, which is the argument against writing today's number in either place.Carriers of the fact — swept for the fact, not for the card's list
The card names two sites. The fact has seven carriers; five were already in a form that cannot go stale, so only the two the card names are edited.
scripts/check-shell-escape-residue.mjsdocblock, "203 of today's 207 files"summarise()— the function that prints the live per-root population. Staleness mode left behind: none; a rename of that identifier breaks in-file rather than drifting silently.github/workflows/lint.yml:291— "206 file(s) and 1309 fenced block(s)"origin/main28cfff4". Verified by re-running the gate against an extracted28cfff4tree: it prints that string verbatimscripts/check-bash32-floor.mjs:51— the same quotecontent/docs/guide/ci-cd-pipeline.md, Shell Escape Residue section6aeba67): 4 files, 20 fences".md/.mdxunder.claude/today is under.claude/skills/(4 of 4)"coverage -- .claude: 4/4on every run and reds when a document escapes a declared root.github/workflows/changeset-release.yml— "73 files / 1996 tests" (card said line 1035; it is line 1087 today)Test Files/Testslinecontent/docs/guide/ci-cd-pipeline.md:1531— "112 test files / 3360 tests onmain@59a3a233d"The
~1 s / ~4 s / ~50 scolumn is kept — it is what the scoping decision was made on — but its summary line is now dated (Measured green on a real rendered tree, 2026-08-25) with a note that the suite has grown since, so the wall clocks are that day's readings rather than a claim about today.Examined and deliberately not touched (same block, different facts, both true or unverifiable):
.changeset/config.jsonhas onefixedgroup of 40 packages.QUICK_REFERENCE.mdor aCHANGELOG.mdis underscripts/__tests__; six carry code-level references, the three matches outside that directory mention those files only in prose). The count itself has no stated definition of "reads", so it cannot be re-derived unambiguously — re-counting it would be exactly the move this card exists to stop. Left as is, reported rather than edited.What pins any of this
Nothing pins either edited numeral — that is the card's second finding, and it is confirmed: the pin family objectui#7448 / objectui#7825 / objectui#7888 pins numerals in workflow headers but not this one, so site 2 looked pinned and was not. No test in
scripts/__tests__/reads1996,73 files,207 filesor203. Site 1's repair replaces that gap with something better than a pin: the sentence now points at the identifier whose output carries the live figure.Verification (real output)
check-shell-escape-residueafter the edit — the run whose own verdict line the old sentence contradicted:The control for leaving A2 and A3 alone — the same gate, run against a tree extracted at
28cfff4, the commit those two carriers name:pnpm test scripts/__tests__(through the shared verify lock), which contains every workflow pin test and the gate's own suite — before and after are the same green:Other gates, exit codes captured before any pipe:
Changeset: none. Not a guess —
check-changeset-presencereports2 file(s) changed, 0 of them published source of a package the release covers, 0 of them a manifest whose published contract moved.Draft by dispatch: this PR is left in draft for a human to merge.
🤖 Generated with Claude Code
Generated by Claude Code
Generated by Claude Code