Skip to content

DO NOT MERGE: Create abnormalContractilityOfAnatomicalEntity.yaml - #609

Open
nicolevasilevsky wants to merge 2 commits into
masterfrom
nicolevasilevsky-patch-4
Open

DO NOT MERGE: Create abnormalContractilityOfAnatomicalEntity.yaml#609
nicolevasilevsky wants to merge 2 commits into
masterfrom
nicolevasilevsky-patch-4

Conversation

@nicolevasilevsky

Copy link
Copy Markdown
Member

No description provided.

@matentzn

Copy link
Copy Markdown
Collaborator

Awesome thanks! Can you add a comment on how to exactly distinguish this pattern from abnormalConstriction? In which cases should we prefer which one?

@nicolevasilevsky

Copy link
Copy Markdown
Member Author

Hm, I'm not sure if we need both, I'll ask Peter.

(This exercise is really helpful in identifying these types of issues and areas where we can consolidate!)

@nicolevasilevsky

Copy link
Copy Markdown
Member Author

Actually, now that I think about it more, contractility has more to do with the action of contracting. I'll add some more text to the description

@nicolevasilevsky

Copy link
Copy Markdown
Member Author

ready for your review @matentzn

@matentzn

Copy link
Copy Markdown
Collaborator

I think this gets us on a bit of thin ice, conflating traits like contraction with "potential of contraction"; I would really prefer to use the GO pattern for this case (inheres in some (GO:heart contraction)), but since this is the communities call, not mine, we will accept this one for now. @dosumis please sanity check this decision. :) Thanks.

@pnrobinson

Copy link
Copy Markdown

Constriction usually means a fixed, loss of un-contraction. Contractility is the potential to contract (the heart is contractile). So, they are not synonyms!

@nicolevasilevsky

Copy link
Copy Markdown
Member Author

@nicolevasilevsky nicolevasilevsky changed the title Create abnormalContractilityOfAnatomicalEntity.yaml DO NOT MERGE: Create abnormalContractilityOfAnatomicalEntity.yaml Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants