Conversation
Alizter
force-pushed
the
push-ylquwslvwtoo
branch
from
September 8, 2026 16:08
e571d70 to
2cd1a80
Compare
Treat slash-terminated semantic values as directory-like in Bash and Zsh, preventing completion from inserting a trailing space before the path is complete. Fixes ocaml#16357 Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
force-pushed
the
push-ylquwslvwtoo
branch
from
September 8, 2026 16:15
2cd1a80 to
7c8ee01
Compare
Alizter
changed the title
Alizter
marked this pull request as ready for review
September 8, 2026 16:42
ElectreAAS
reviewed
Sep 11, 2026
ElectreAAS
left a comment
ElectreAAS
left a comment
Collaborator
There was a problem hiding this comment.
This PR fixes a currently unobservable bug: there are no command that complete directory names
Nonetheless this actually fixes it, so I am passively approving it.
I think it should stay open until a command actually makes use of the feature, but we could also merge it now if people prefer.
- tested on zsh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adjust bash and zsh completion support so that directory candidates are not followed by a space.