Conversation
rgrinberg
force-pushed
the
push-vkmvxuwwvlts
branch
from
September 13, 2026 14:05
94e4984 to
819f029
Compare
Add a typed record builder using curried constructors for decoding and field projections for encoding. Completed builders remain composable as field codecs. Migrate straightforward RPC records, including calls, initialization, registry entries, locations, diagnostics, messages, jobs, and promotion requests. Preserve field parsing order and the existing wire formats, including V1 diagnostic tags, and update structural digest snapshots. Add legacy-codec comparisons, wire-format snapshots, and round-trip tests, plus coverage for versions, errors, recursion, empty records, and records beyond eight fields. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
force-pushed
the
push-vkmvxuwwvlts
branch
from
September 13, 2026 16:00
819f029 to
2ad1313
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Record codecs currently require converting records to and from tuples, with arity-specific combinators and repeated positional bookkeeping.
Add
Conv.Record, a typed builder pairing a curried constructor with field projections. Completed builders remain composable as field codecs. Port straightforward named-field RPC codecs for calls, initialization, registry entries, locations, current and V1 diagnostics, messages, jobs, promotion requests, and formatting requests. Also use the builder in the versioned add RPC test. Leave conversions with separate validation, inline-variant payloads, and positional wire types unchanged.Legacy-codec comparisons, captured wire-format snapshots, and round-trip tests check compatibility, including optional fields, styled diagnostics, V1 unit tags, and registry files. The wire formats are unchanged; structural digest snapshots change. Builder tests also cover errors, versions, recursion, empty records, and records beyond eight fields.
Local validation encounters the same two baseline bubblewrap UID-map permission failures in
sandbox-actions; the build, formatting, and Stdune/RPC tests pass.